c2fd5cefa4
Remove `visit_bytes` implementation from `FromStrVisitor`
...
This visitor is meant to deserialize strings using `FromStr` not
bytes.
2021-01-13 09:57:09 +11:00
e6e23e9dd6
Rename `HexVisitor` to `FromStrVisitor`
...
The visitor works with all types that implement `FromStr`. Whether or
not that ends up being hex encoding depends on the implementation
of `FromStr`.
2021-01-13 09:54:33 +11:00
18890d3b86
Extend schnorr-sig serde test suite with owned and slice variants
2021-01-12 11:52:24 +11:00
b4040f0a82
Update test names to reflect what they are doing
...
These tests are testing more than just the signature serialization.
2021-01-12 11:52:06 +11:00
1f08a313e5
Replace serde macros with generic visitor module
...
Co-authored-by: Elichai Turkel <elichai.turkel@gmail.com>
Co-authored-by: Sebastian Geisler <sebastian@blockstream.io>
2021-01-12 11:51:29 +11:00
65ff814a39
rename `rust_secp_fuzz` to `fuzzing`
2021-01-11 19:14:42 +00:00
1f043216a0
Add ability to randomize context without the `rand` feature.
...
There is little reason to pull in the `rand` dep just for the `Rng`
trait for users who want to randomize contexts. We should expose a
randomize function that just takes 32 bytes.
2020-12-29 16:45:07 -05:00
d1714ce0ac
fuzz: disable sig-grinding tests, prevent spin-looping
2020-12-28 18:55:33 +00:00
96862b6a74
fuzz: implement recoverable signatures, get all tests passing, run them in CI
2020-12-28 18:42:46 +00:00
b811ec133a
fuzz: only replace signing and verification, leave everything else alone
...
We can now run unit tests with the fuzz feature on, and they'll pass,
which is some assurance that fuzzing with the feature on won't lead to
spurious failures due to the fuzz harness inadequately simulating message
signing.
2020-12-23 17:59:52 +00:00
40c31342f2
ffi: make function types nullable
2020-12-23 17:59:52 +00:00
a2c25f2e83
Merge pull request #259 from p2pderivatives/implement-low-r-signing
...
Implement low r signing
2020-12-22 23:28:34 +00:00
b31bf2f611
Merge pull request #258 from thomaseizinger/better-wasm-tests
...
Run more tests in wasm
2020-12-22 06:12:01 +00:00
1d166d061b
Implement low r signing
2020-12-22 14:50:37 +09:00
a584643486
Use ManuallyDrop
...
Suggested by clippy, we need to use ManuallyDrop for these types in
order to correctly free up the memory.
2020-12-22 14:56:17 +11:00
c38136b6bc
Use for loop instead of map
...
Currently we are misusing `map` on an iterator to loop `n` times,
additionally the assertion is pointless. Use a for loop and assert
against the length of the set.
2020-12-22 14:56:17 +11:00
c92b946493
Remove unnecessary clone
...
Type is `Copy`, no need for clone.
2020-12-22 14:56:17 +11:00
ef23cb8167
Return Ok directly
...
Clippy emits warning:
warning: passing a unit value to a function
Just return `Ok(())` after calling `fill_bytes`.
2020-12-22 14:56:17 +11:00
34ad4110f1
Remove unused error return value
...
This helper never returns an error, remove the `Result` return type.
Found by clippy.
2020-12-22 14:56:17 +11:00
ed29f12216
Remove unnecessary return statements
...
Found by clippy. We don't need a `return` for the final statement.
2020-12-22 13:38:02 +11:00
4e87e6fe94
Implement is_empty method
...
Clippy warns of missing `is_empty`, trivially implement it by calling
through to `self.data.is_empty()`.
2020-12-22 13:37:25 +11:00
8b8e482f79
Run more tests in wasm
...
Instead of repeating ourselves in defining one big test for the wasm
target, we can override the `test` attribute with the `wasm-bindgen-test`
one and therefore automatically run all (supported) tests in wasm.
Unfortunately, wasm doesn't support catching panics yet which means we
have to disable the `test_panic_raw_ctx` test.
2020-12-22 10:30:56 +11:00
767246a282
Make preallocated use AlignedType
2020-12-18 12:48:19 +02:00
fd206ab57c
Replace use of boxes with global allocator
2020-12-18 12:48:19 +02:00
ea027ce258
schnorrsig: change tweak_add_check to return a bool, take a fixed-length array
2020-12-09 16:49:48 +00:00
0ec8fab82c
stop explicitly casting references to rawptrs
2020-11-30 02:47:34 +00:00
37049d743e
schnorrsig: expose tweak_check_add API
2020-11-27 18:42:14 +00:00
12b0abbcf8
make `ffi::Type::new` functions all unsafe, expand documentation
2020-11-27 18:42:12 +00:00
be9a78f39e
Merge pull request #237 from p2pderivatives/add-bip340-schnorr
...
Add bip340 schnorr
2020-11-27 18:04:44 +00:00
9083babbe2
Merge pull request #248 from justinmoon/pubkey-ordering
...
Implement lexigraphic ordering for PubKey
2020-11-26 03:03:17 +00:00
6f8a480974
Implement lexigraphic ordering for PubKey
2020-11-25 19:27:31 -06:00
1859ddc28a
switch from travis to github workflows
2020-11-10 23:58:03 +00:00
0c937d04f5
Add key::PublicKey to schnorrsig::PublicKey conversion
2020-11-10 14:15:34 +09:00
09b04560bc
Add schnorrsig module
2020-11-10 13:43:34 +09:00
47b33828bc
Add serde macros for public keys
2020-11-09 16:00:28 +09:00
9e5a351ea7
remove redundant code after MSRV bump
2020-08-27 22:51:36 +03:00
19f5138925
Update MSRV to 1.29; increase version to 0.19 and -sys version to 0.3
2020-08-27 14:18:06 +00:00
c69d43d84e
Update key.rs to use the new seckey functions
2020-08-26 21:16:19 +00:00
5c451f78c6
Merge pull request #207 from sorpaas/sp-message-zero
...
Allow all-zero messages
2020-08-26 18:02:51 +00:00
3692c94a0f
Merge pull request #220 from rantan/add_negate_support
...
Add negate support
2020-08-26 17:43:46 +00:00
2046a40905
Randomize context on initialization
...
Signed-off-by: Sebastian Geisler <sebastian@blockstream.io>
2020-08-03 12:07:26 +02:00
a959de4174
Add an optional global, static context
2020-07-08 16:05:42 +02:00
02ed0616e4
Add assert for the response of ffi negate interface
...
The interfaces for negate should always returns 1 as mentioned secp256k1.h L574, L563.
But in the future it might return 0 if the seckey or pubkey is invalid, but our type system doesn't allow that to ever happen.
2020-06-10 09:59:55 +09:00
d45f709cd4
Add negation support
2020-06-09 10:05:07 +09:00
8979a932ab
Document proper usage of `from_slice`
2020-05-14 18:24:40 +02:00
0d857533fa
Add optional bitcoin_hashes feature to implement ThirtyTwoByteHash
2020-05-14 18:24:39 +02:00
0dcc59c2b9
Add doctest to Secp256k1::verify
2020-05-05 17:30:07 +03:00
0782872fb0
Merge pull request #208 from TheBlueMatt/202-04-wasm
...
Re-support WASM via simple stub headers
2020-04-29 19:48:03 +00:00
affc6b4027
Add sanity checks for wasm32 for size and alignment of types
2020-04-29 15:32:57 -04:00
d9d398ccc9
Re-support WASM via simple stub headers
...
libsecp256k1 really only barely uses libc at all, and in practice,
things like memcpy/memcmp get optimized into something other than a
libc call. Thus, if we provide simple stub headers, things seem to
work with wasm-pack just fine.
2020-04-29 15:32:54 -04:00
99a43ced56
Fix Secp256k1::verify docs
2020-04-22 17:58:27 +03:00
9250ae49ce
Allow all-zero messages
2020-04-09 14:26:31 +02:00
86751b2d74
Merge pull request #201 from elichai/2020-03-ecdh
...
Simplify callback logic to returning raw coordinates
2020-04-06 14:48:57 +00:00
3fd089712c
Merge pull request #205 from elichai/2020-03-bench
...
Fix broken benchmarks
2020-04-05 21:38:33 +00:00
b2edf157cd
Fix broken benchmarks
2020-04-05 11:08:29 +03:00
ab59498e04
Merge pull request #199 from elichai/2020-02-external-symbols
...
Fix typos in the external-symbols feature(bug)
2020-04-04 21:31:13 +00:00
4b410fc202
Add constant of the prime of the curve field.
2020-03-06 09:15:32 +09:00
2eff118d03
Simplify callback logic to returning raw coordinates
2020-03-01 13:46:25 +02:00
2f897d8a93
Removed no longer used dont_replace_c_symbols feature
2020-02-09 16:37:59 +02:00
4b740911c6
Merge pull request #180 from elichai/2019-11-SharedSecret
...
Alternative: Passing custom hash functions to ECDH
2019-12-09 21:11:30 +00:00
5619f2a5df
Add an unsafe variant of new_with_has called new_with_hash_no_panic
2019-12-09 22:53:24 +02:00
124c1f3c7c
feature gate new_with_hash with std only, added catch_unwind
2019-12-05 18:05:40 +02:00
d2c4e5a846
Wrap Secp256k1 from raw context in a ManuallyDrop
2019-12-05 17:51:59 +02:00
f80428258c
Add tests for the new SharedSecret::new_with_hash() function
2019-12-05 17:46:24 +02:00
af8fa21a20
Add 'new_with_hash' function to SharedSecret
2019-12-05 17:46:23 +02:00
9759cb07f5
Replace SharedSecret with a more generic alternative
2019-12-05 17:45:24 +02:00
724c49fff9
Add secp256k1-sys
2019-11-27 21:02:42 +00:00
02f66177f0
Merge pull request #179 from elichai/2019-11-raw-context
...
Creating context from raw pointer
2019-11-27 20:34:43 +00:00
9523e093c1
Add tests for raw context
2019-11-27 22:05:27 +02:00
5f8096e8a8
Add functions to create from raw context
2019-11-27 22:05:23 +02:00
cf22f60919
Merge pull request #162 from elichai/2019-09-ffi
...
Fixes and tests for the ffi
2019-11-27 20:01:17 +00:00
1e711f194c
Merge pull request #184 from elichai/2019-11-context
...
Fix a safety problem and make the Context trait unimplementable
2019-11-27 19:58:44 +00:00
9522f7e4a4
Make Context::deallocate unsafe fn
2019-11-27 17:42:01 +02:00
fe688ada65
Make the Context trait unimplementable
2019-11-27 17:36:06 +02:00
47b2555e80
Merge pull request #182 from rodoufu/code_imp
...
Updating libraries and small code improvements
2019-11-22 16:02:33 +00:00
1b0c57377a
Remove trailing whitespace
2019-11-20 20:36:18 +01:00
825493bea9
Small code improvements.
2019-11-17 22:10:40 -03:00
a4ccab7431
Libraries.
2019-11-17 22:04:11 -03:00
d900dcd1c9
Merge pull request #177 from elichai/2019-10-csymbols
...
Add a feature to disable replacing C symbols with rust
2019-10-29 01:39:08 +00:00
349b2eac06
Add a 'dont_replace_c_symbols' feature for not replacing C's symbols with rust. isn't compatible with no-std
2019-10-28 23:05:38 +02:00
f09ff2a9de
Disable some useless lints
2019-10-28 15:20:04 -04:00
06b2bebce8
Add a test for the types
2019-09-14 22:59:36 +03:00
5b10d1b226
Fix bad ffi declarations
2019-09-14 21:12:59 +03:00
eddfe03dbc
Merge pull request #151 from elichai/2019-08-Cptr-null
...
Explicit checks for ZST + null fallbacks
2019-08-21 23:03:30 +00:00
d7461e4cdc
Add zst tests and some other parsing tests
2019-08-21 18:06:02 -04:00
ddb8e4fdf2
Explicit checks for empty slices
2019-08-21 13:09:36 -04:00
b7e20c5b12
Changed all as_*ptr() to the safer CPtr trait
2019-08-21 13:09:36 -04:00
66ab70f991
Added a C Ptr trait that returns a null pointer for ZSTs
2019-08-21 13:09:20 -04:00
255d1ddd60
Remove TODOs for ffi functions for setting secp256k1 callbacks
...
We would not want to use these functions internally because we rely on
USE_EXTERNAL_DEFAULT_CALLBACKS to provide the callbacks at link time,
see f7a4a7ef57
2019-08-20 14:47:33 +02:00
8e701b75b2
Replacing usage of the unsafe `blank` function to the `new` function
...
Signed-off-by: Elichai Turkel <elichai.turkel@gmail.com>
2019-08-16 14:15:31 -04:00
389e1e2449
Removing usage of `mem::uninitialized()` and deprecating the `blank()` functions
...
Signed-off-by: Elichai Turkel <elichai.turkel@gmail.com>
2019-08-16 14:15:27 -04:00
16fc4ee3fc
Fixed the counter Rng
2019-08-13 10:41:39 -04:00
0f25474805
Implement hex human-readable serde for PublicKey
2019-07-23 17:50:56 +02:00
ccac3ead25
Implement fmt::LowerHex for SecretKey and PublicKey
2019-07-23 17:50:54 +02:00
7356705b61
Added a test for create/destroy functions
2019-07-14 16:35:51 -04:00
75784ec26f
Implemented context create/destroy in rust
2019-07-14 16:35:47 -04:00
96ca40faed
Exposed generic functions to create the Context
2019-07-04 21:36:32 -04:00
49f0cc1c46
Updated the fuzzing dummy functions
2019-07-04 19:13:26 -04:00
811e8d24e9
Removed context_create/destroy/clone and scratch_create/destroy/clone functions.
2019-07-04 19:09:04 -04:00
9186f0223a
Added preallocation size functions and added a test for the preallocation
2019-07-04 18:40:08 -04:00
1c0ae7d4ba
Added structs and functions for manual allocation
2019-07-04 18:40:07 -04:00
b4b52a9858
Moved the context specific traits/enums into a separate file with `std` gate
2019-07-04 18:40:07 -04:00
5f93474512
Added the preallocated FFI
2019-07-04 18:40:04 -04:00
68c5c5edbf
implemented strlen to deref the callback message
2019-07-03 17:50:16 -04:00
8022757681
Added a c_char implementation
2019-07-03 17:48:35 -04:00
f7a4a7ef57
Added manual external callbacks that panics
2019-07-03 17:48:35 -04:00
0e6ff34009
Fix imports when using recovery with fuzztarget feature
2019-05-29 00:02:11 +00:00
be457afdae
Removed ffi call from Display implementation
2019-05-21 22:05:18 +03:00
0bf88fe444
Merge pull request #109 from jonasnick/human-sigs
...
Add human readable serialization to Signatures
2019-05-21 17:50:41 +00:00
ebf50df1d1
Add human readable serialization to Signatures
2019-05-21 10:34:18 +00:00
28934ab5a7
Only display existing signature bytes
2019-05-21 10:22:05 +00:00
16da1a854c
Move recovery ffi into recovery module and feature gate C-secp recovery module
2019-05-21 07:52:08 +00:00
c7eecd159e
Feature gate recovery module
2019-05-21 07:02:11 +00:00
264b368ee0
Move recovery to its own module
2019-05-20 19:11:59 +00:00
3825ed35a7
Add human readable serialization and deserialization to Secret Key
2019-05-14 11:15:18 +00:00
ab4320f8cc
Merge pull request #100 from elichai/master
...
Add no-std support
2019-05-10 23:32:52 +02:00
dfcf74f9d0
Added a new struct for the DER serialized signature
2019-05-11 00:11:42 +03:00
90faf434c9
Merge pull request #104 from alekseysidorov/fix_rand
...
Fix `Rand` trait bounds.
2019-05-01 01:47:43 +00:00
312b9a55fc
Added Error::description copied c_void impl from core::ffi::c_void
2019-04-30 22:07:27 +03:00
91c43e7320
Add as_mut_ptr to PublicKey
2019-04-16 18:48:24 +00:00
2536c5a3c4
Fix rand trait bounds.
2019-04-16 16:35:33 +03:00
e98975a1c0
Added backwards support without the crate keyword
2019-04-14 12:09:43 +03:00
ab8066eb1a
Replaced the std::os::raw c types with types.rs
2019-04-14 12:09:42 +03:00
11ce86681f
Replaced std with core, and made std::error::Error optional through feature
2019-04-14 12:09:36 +03:00
6eaacb19c5
Add raw context getter to Secp256k1 struct
2019-03-01 19:39:55 +00:00
a8a3afe8db
Fix clippy errors
...
Changes include cargo-fix generated, Default impls
2019-02-25 20:12:25 -08:00
bafef68c56
Bumps rand to 0.6.3 & associated updates
2019-02-25 20:09:43 -08:00
f90e9f3454
Stop checking context flags for secp256k1_ecdh as its not required
2019-01-16 16:02:24 -05:00
a74cbb6781
Sync fuzztarget combine with tweak_add since real functions do that
...
Some new fuzz tests I was writing ended up failing because two
nodes came up with different keys because adding public keys and
adding a tweak to a private key and multiplying by the generator
should get the same thing.
2019-01-08 16:12:40 -05:00
9c45944a5f
Remove dependency on libc
2018-12-27 14:39:54 +01:00
b470f70e90
Merge pull request #57 from rust-bitcoin/2018-08-no-index
...
remove `ops::Index` impls for `Signature`
2018-12-03 14:27:08 +01:00
e5a02bd9a0
add `ThirtyTwoByteHash` hash trait which can be implemented for easier conversion of things to `Message`s
2018-11-10 13:12:10 +00:00
1f4a4c11a3
change add_*_assign and mul_*_assign to use a byteslice as a tweak, rather than a `SecretKey`
...
This makes more conceptual sense and does not add any new error paths, since even
valid `SecretKey`s were able to be invalid tweaks.
2018-11-10 13:08:18 +00:00
f93b959b4a
disallow Messages that are not valid secret keys to prevent mistakes related to 0
2018-11-10 13:05:11 +00:00
8d2347602a
remove `ops::Index` impls for `Signature`
2018-11-10 12:56:19 +00:00
7fbaf2f91b
remove unsafe ZERO_KEY and deprecated ONE
2018-11-10 12:56:19 +00:00
4b88cfc2fc
Merge pull request #78 from rust-bitcoin/2018-11-remove-without-caps
...
Update upstream libsecp; remove `without_caps` and all use of dummy contexts
2018-11-10 12:51:14 +00:00
8986aa3d71
export `serde`, `rand` and `libc`; update version to 0.11.5
2018-11-07 20:18:55 +00:00
223eb41fd0
remove context object from ECDH
2018-11-06 22:16:24 +00:00
93abca5896
remove `without_caps` and every function that used a cap-less context
2018-11-06 22:16:24 +00:00
4653100b7a
update upstream libsecp256k1 to 314a61d72474aa29ff4afba8472553ad91d88e9d
2018-11-06 22:16:13 +00:00
68c838f357
change `Debug` impl for `Signature` to use `Display`
2018-11-03 15:52:07 +00:00
30aa3a0c28
add `fmt::Display` and `str::FromStr` impls for `Signature`
2018-11-03 15:52:05 +00:00
572adb2873
add `FromStr` implementation for key types
2018-11-03 15:52:03 +00:00
a810880c54
restore missing `mem` import in key.rs
2018-08-22 20:43:20 +00:00
0d41c23c21
Revert "remove PublicKey::combine"
...
This reverts commit 17450e91fd
2018-08-22 20:18:25 +00:00
c773dfbc8d
remove unused import that was causing warning
2018-08-22 16:40:05 +00:00
2c18a16858
Merge pull request #50 from rust-bitcoin/2018-08-no-combine
...
remove PublicKey::combine
2018-08-21 18:36:27 +00:00
3563c5f305
Merge pull request #46 from rust-bitcoin/2018-08-context-debug
...
add Debug impl to context object
2018-08-20 18:34:13 +00:00
1f73a784cb
Merge pull request #52 from rust-bitcoin/2018-08-display-keys
...
add Display impl for the key types which outputs their hex representation
2018-08-20 18:32:53 +00:00
Thomas Eizinger
Elichai Turkel
Andrew Poelstra
Matt Corallo
Tibo-lg
Tobin Harding
Justin Moon
Sebastian Geisler
Kohei Taniguchi
Kirill Fomichev
Wei Tang
Steven Roose
Tony Jin
Rodolfo Araujo
Tim Ruffing
Jonas Nick
Aleksei Sidorov
François Garillot
Pierre Krieger
Tim Ruffing