79119e8123
Skip context randomization in fuzzing to improve performance
2021-06-08 19:17:08 +00:00
c486ca10c7
Use a global static context in fuzzing, reducing overhead
2021-06-08 19:17:08 +00:00
940a51c2c6
Reduce cryptography usage in --cfg=fuzzing
...
This reduces the usage of real cryptography in --cfg=fuzzing,
specifically replacing the secret->public key derivation with a
simple copy and ECDH with XOR of the public and private parts
(plus a stream of 1s to make a test pass that expected non-0
output).
It leaves secret tweak addition/multiplication as-is.
It also changes the context creation to over-allocate and store
the context flags at the end of the context buffer, allowing us
to easily test context flags in each function.
While it would be nice to have something fancier (eg XOR-based),
its not immediately obvious how to accomplish this, and better to
fix the issues I have than spend too much time on it.
Fixes #271 .
This partially reverts b811ec133a
2021-06-08 19:17:08 +00:00
f2e4b297e1
Do not test secret->public derivation or pk validity in fuzzing cfg
...
In the next commit the secret->public key derivation in fuzzing cfg
is changed to be simpler, as well as the validity rules of public
keys relaxed.
This adds a new test to ensure random keys can be added, not just
the hard-coded keys test that exists today.
2021-06-08 19:17:07 +00:00
5ff59f7f5c
Merge pull request #289 from TheBlueMatt/2021-03-no-vis
...
Reduce visibility on secp-sys symbols
2021-06-08 18:12:55 +00:00
e89fd5d269
Merge pull request #291 from p2pderivatives/add-combine-keys
...
Add combine_keys function to PublicKey
2021-06-08 18:09:35 +00:00
a5dfd09e94
Merge pull request #294 from LNP-BP/feat/from_secret_key
...
Adding schnorrsig::KeyPair::from_secret_key convenience function
2021-06-08 18:05:20 +00:00
b686de76fb
Merge pull request #279 from TheBlueMatt/master
...
Add a global-context-less-secure feature which skips randomization
2021-06-08 02:09:25 +00:00
ce930ab6b7
Add a global-context-less-secure feature which skips randomization
...
This is useful for us downstream as we wish to target WASM with a
global context, and using rand in such a build doesn't seem like a
safe idea.
2021-06-08 01:48:50 +00:00
cf8921a338
Merge pull request #302 from jules23/recovery-no-std-test
...
Touch recovery module in no_std_test
2021-05-23 12:02:47 +03:00
c925644b74
Touch recovery module in no_std_test
2021-05-20 07:18:42 -06:00
a66f581b36
Merge pull request #296 from sanket1729/seckey_fromstr
...
Fix SecretKey FromStr bug
2021-04-29 11:34:57 +03:00
b48d1eafc5
Merge pull request #297 from apoelstra/2021-04--0.20.2
...
release secp256k1 0.20.2
2021-04-28 16:19:38 +00:00
5307f9ba6c
release secp256k1 0.20.2
2021-04-27 22:16:58 +00:00
6265b2558a
Fix SecretKey FromStr bug
...
Secret::from_str did not check if the secret key
was a valid one or not.
2021-04-26 14:17:39 -07:00
3c2bee31f2
Merge pull request #270 from thomaseizinger/serde-owned-types
...
Rebased version of `[Alternative] Allow deserializing from owned types` + support for new schnorr module
2021-04-21 19:06:29 +03:00
bf9a276342
Adding schnorrsig::KeyPair::from_secret_key convenience function
2021-04-12 15:25:50 +02:00
7d32182537
Add combine_keys function to PublicKey
2021-04-08 06:28:03 +09:00
ee1103a1f3
Reduce visibility on secp-sys symbols
...
cc-rs builds C dependencies with reduced visibility to avoid
exporting the C symbols all the way out to any rust-built shared
libraries however we override it with SECP256K1_API. We should
avoid doing this, allowing LTO/DCE to do its work.
2021-04-07 11:21:16 -04:00
63f4de78ce
Merge pull request #290 from real-or-random/202103_panic_from_c
...
Manually test that panicking from C will abort the process
2021-04-07 15:00:58 +00:00
1eb2c32df7
Manually test that panicking from C will abort the process
...
Panicking from C is not UB in newer rust versions and will reliably
trigger an abort (without unwinding). In older rust versions, it is
technically UB but empirically it seems to "just work" (and what should
it realistically do except crashing, which is what we intent).
Since there's potentially no unwinding, we can't test this behavior
using [should_panic]. This PR will instead check the libtest output
explicitly in our CI tests.
Fixes #228 .
2021-03-24 21:54:02 +01:00
4ae0e7ebd1
Merge pull request #284 from fanatid/patch-1
...
Use CARGO_CFG_TARGET_ARCH instead TARGET in build.rs
2021-03-12 19:18:24 +00:00
0a91f2ba2b
Use CARGO_CFG_TARGET_ARCH instead TARGET in build.rs
2021-03-08 22:54:21 +03:00
3bff596948
Merge pull request #277 from LNP-BP/fix/error-derive
...
More standard derives for Error
2021-02-10 18:03:34 +00:00
519857cd83
More standard derives for Error
2021-01-30 12:35:41 +01:00
8e61874d77
Merge pull request #275 from gregdhill/master
...
use core instead of std for wasm sanity checks
2021-01-25 16:00:35 +00:00
c86808fac7
use core instead of std for wasm sanity checks
...
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
2021-01-20 14:55:48 +00:00
a24e27e94b
Merge pull request #269 from apoelstra/2021-01--rename-fuzz-feature
...
Rename `rust_secp_fuzz` config flag to `fuzzing`
2021-01-15 15:00:23 +00:00
c2fd5cefa4
Remove `visit_bytes` implementation from `FromStrVisitor`
...
This visitor is meant to deserialize strings using `FromStr` not
bytes.
2021-01-13 09:57:09 +11:00
e6e23e9dd6
Rename `HexVisitor` to `FromStrVisitor`
...
The visitor works with all types that implement `FromStr`. Whether or
not that ends up being hex encoding depends on the implementation
of `FromStr`.
2021-01-13 09:54:33 +11:00
18890d3b86
Extend schnorr-sig serde test suite with owned and slice variants
2021-01-12 11:52:24 +11:00
b4040f0a82
Update test names to reflect what they are doing
...
These tests are testing more than just the signature serialization.
2021-01-12 11:52:06 +11:00
1f08a313e5
Replace serde macros with generic visitor module
...
Co-authored-by: Elichai Turkel <elichai.turkel@gmail.com>
Co-authored-by: Sebastian Geisler <sebastian@blockstream.io>
2021-01-12 11:51:29 +11:00
ca3caf9c94
bump version to 0.20.1
2021-01-11 19:15:10 +00:00
65ff814a39
rename `rust_secp_fuzz` to `fuzzing`
2021-01-11 19:14:42 +00:00
5f1622f917
Merge pull request #257 from apoelstra/2020-12--no-endo
...
update libsecp, remove endomorphism feature flag and release 0.20.0
2021-01-03 20:10:23 +00:00
c534b54e11
Merge pull request #267 from TheBlueMatt/master
...
Add ability to randomize context without the `rand` feature.
2020-12-29 22:25:15 +00:00
1f043216a0
Add ability to randomize context without the `rand` feature.
...
There is little reason to pull in the `rand` dep just for the `Rng`
trait for users who want to randomize contexts. We should expose a
randomize function that just takes 32 bytes.
2020-12-29 16:45:07 -05:00
c4d2fefa70
rust-secp 0.20.0
2020-12-29 19:31:24 +00:00
d12be7966c
drop unnecessary no_mangle annotations on non-exported functions
2020-12-29 19:30:59 +00:00
58f946fcc8
secp-sys: remove now-unneeded endianness check from build.rs
2020-12-29 17:15:56 +00:00
e687622a81
bump secp-sys version; drop endomorphism flag
2020-12-29 17:15:56 +00:00
a93d671d05
update libsecp to 98dac87839838b86094f1bccc71cc20e67b146cc
2020-12-29 17:15:51 +00:00
e5d9e088cf
secp-sys: update scratch_impl.patch for upstream changes
2020-12-29 17:15:21 +00:00
a9049f8eb2
Merge pull request #266 from junderw/patch-1
...
Fix link_name for secp256k1_ec_seckey_negate
2020-12-29 17:12:36 +00:00
867b920aac
Merge pull request #264 from rust-bitcoin/2020-12--no-extsymb2
...
redo fuzz target
2020-12-28 19:48:11 +00:00
75d717729a
fuzz: fix elichai's nits
2020-12-28 19:01:12 +00:00
d1714ce0ac
fuzz: disable sig-grinding tests, prevent spin-looping
2020-12-28 18:55:33 +00:00
96862b6a74
fuzz: implement recoverable signatures, get all tests passing, run them in CI
2020-12-28 18:42:46 +00:00
51bc0b1c0c
Fix link_name for secp256k1_ec_seckey_negate
2020-12-28 15:06:18 +09:00
Matt Corallo
Andrew Poelstra
Elichai Turkel
Jules Comte
sanket1729
Dr Maxim Orlovsky
Tibo-lg
Tim Ruffing
Kirill Fomichev
Gregory Hill
Thomas Eizinger
Jonathan Underwood