b811ec133a
fuzz: only replace signing and verification, leave everything else alone
...
We can now run unit tests with the fuzz feature on, and they'll pass,
which is some assurance that fuzzing with the feature on won't lead to
spurious failures due to the fuzz harness inadequately simulating message
signing.
2020-12-23 17:59:52 +00:00
40c31342f2
ffi: make function types nullable
2020-12-23 17:59:52 +00:00
a2c25f2e83
Merge pull request #259 from p2pderivatives/implement-low-r-signing
...
Implement low r signing
2020-12-22 23:28:34 +00:00
b31bf2f611
Merge pull request #258 from thomaseizinger/better-wasm-tests
...
Run more tests in wasm
2020-12-22 06:12:01 +00:00
1d166d061b
Implement low r signing
2020-12-22 14:50:37 +09:00
a584643486
Use ManuallyDrop
...
Suggested by clippy, we need to use ManuallyDrop for these types in
order to correctly free up the memory.
2020-12-22 14:56:17 +11:00
c38136b6bc
Use for loop instead of map
...
Currently we are misusing `map` on an iterator to loop `n` times,
additionally the assertion is pointless. Use a for loop and assert
against the length of the set.
2020-12-22 14:56:17 +11:00
c92b946493
Remove unnecessary clone
...
Type is `Copy`, no need for clone.
2020-12-22 14:56:17 +11:00
ef23cb8167
Return Ok directly
...
Clippy emits warning:
warning: passing a unit value to a function
Just return `Ok(())` after calling `fill_bytes`.
2020-12-22 14:56:17 +11:00
34ad4110f1
Remove unused error return value
...
This helper never returns an error, remove the `Result` return type.
Found by clippy.
2020-12-22 14:56:17 +11:00
ed29f12216
Remove unnecessary return statements
...
Found by clippy. We don't need a `return` for the final statement.
2020-12-22 13:38:02 +11:00
4e87e6fe94
Implement is_empty method
...
Clippy warns of missing `is_empty`, trivially implement it by calling
through to `self.data.is_empty()`.
2020-12-22 13:37:25 +11:00
8b8e482f79
Run more tests in wasm
...
Instead of repeating ourselves in defining one big test for the wasm
target, we can override the `test` attribute with the `wasm-bindgen-test`
one and therefore automatically run all (supported) tests in wasm.
Unfortunately, wasm doesn't support catching panics yet which means we
have to disable the `test_panic_raw_ctx` test.
2020-12-22 10:30:56 +11:00
767246a282
Make preallocated use AlignedType
2020-12-18 12:48:19 +02:00
fd206ab57c
Replace use of boxes with global allocator
2020-12-18 12:48:19 +02:00
ea027ce258
schnorrsig: change tweak_add_check to return a bool, take a fixed-length array
2020-12-09 16:49:48 +00:00
0ec8fab82c
stop explicitly casting references to rawptrs
2020-11-30 02:47:34 +00:00
37049d743e
schnorrsig: expose tweak_check_add API
2020-11-27 18:42:14 +00:00
12b0abbcf8
make `ffi::Type::new` functions all unsafe, expand documentation
2020-11-27 18:42:12 +00:00
be9a78f39e
Merge pull request #237 from p2pderivatives/add-bip340-schnorr
...
Add bip340 schnorr
2020-11-27 18:04:44 +00:00
9083babbe2
Merge pull request #248 from justinmoon/pubkey-ordering
...
Implement lexigraphic ordering for PubKey
2020-11-26 03:03:17 +00:00
6f8a480974
Implement lexigraphic ordering for PubKey
2020-11-25 19:27:31 -06:00
1859ddc28a
switch from travis to github workflows
2020-11-10 23:58:03 +00:00
0c937d04f5
Add key::PublicKey to schnorrsig::PublicKey conversion
2020-11-10 14:15:34 +09:00
09b04560bc
Add schnorrsig module
2020-11-10 13:43:34 +09:00
47b33828bc
Add serde macros for public keys
2020-11-09 16:00:28 +09:00
9e5a351ea7
remove redundant code after MSRV bump
2020-08-27 22:51:36 +03:00
19f5138925
Update MSRV to 1.29; increase version to 0.19 and -sys version to 0.3
2020-08-27 14:18:06 +00:00
c69d43d84e
Update key.rs to use the new seckey functions
2020-08-26 21:16:19 +00:00
5c451f78c6
Merge pull request #207 from sorpaas/sp-message-zero
...
Allow all-zero messages
2020-08-26 18:02:51 +00:00
3692c94a0f
Merge pull request #220 from rantan/add_negate_support
...
Add negate support
2020-08-26 17:43:46 +00:00
2046a40905
Randomize context on initialization
...
Signed-off-by: Sebastian Geisler <sebastian@blockstream.io>
2020-08-03 12:07:26 +02:00
a959de4174
Add an optional global, static context
2020-07-08 16:05:42 +02:00
02ed0616e4
Add assert for the response of ffi negate interface
...
The interfaces for negate should always returns 1 as mentioned secp256k1.h L574, L563.
But in the future it might return 0 if the seckey or pubkey is invalid, but our type system doesn't allow that to ever happen.
2020-06-10 09:59:55 +09:00
d45f709cd4
Add negation support
2020-06-09 10:05:07 +09:00
8979a932ab
Document proper usage of `from_slice`
2020-05-14 18:24:40 +02:00
0d857533fa
Add optional bitcoin_hashes feature to implement ThirtyTwoByteHash
2020-05-14 18:24:39 +02:00
0dcc59c2b9
Add doctest to Secp256k1::verify
2020-05-05 17:30:07 +03:00
0782872fb0
Merge pull request #208 from TheBlueMatt/202-04-wasm
...
Re-support WASM via simple stub headers
2020-04-29 19:48:03 +00:00
affc6b4027
Add sanity checks for wasm32 for size and alignment of types
2020-04-29 15:32:57 -04:00
d9d398ccc9
Re-support WASM via simple stub headers
...
libsecp256k1 really only barely uses libc at all, and in practice,
things like memcpy/memcmp get optimized into something other than a
libc call. Thus, if we provide simple stub headers, things seem to
work with wasm-pack just fine.
2020-04-29 15:32:54 -04:00
99a43ced56
Fix Secp256k1::verify docs
2020-04-22 17:58:27 +03:00
9250ae49ce
Allow all-zero messages
2020-04-09 14:26:31 +02:00
86751b2d74
Merge pull request #201 from elichai/2020-03-ecdh
...
Simplify callback logic to returning raw coordinates
2020-04-06 14:48:57 +00:00
3fd089712c
Merge pull request #205 from elichai/2020-03-bench
...
Fix broken benchmarks
2020-04-05 21:38:33 +00:00
b2edf157cd
Fix broken benchmarks
2020-04-05 11:08:29 +03:00
ab59498e04
Merge pull request #199 from elichai/2020-02-external-symbols
...
Fix typos in the external-symbols feature(bug)
2020-04-04 21:31:13 +00:00
4b410fc202
Add constant of the prime of the curve field.
2020-03-06 09:15:32 +09:00
2eff118d03
Simplify callback logic to returning raw coordinates
2020-03-01 13:46:25 +02:00
2f897d8a93
Removed no longer used dont_replace_c_symbols feature
2020-02-09 16:37:59 +02:00
4b740911c6
Merge pull request #180 from elichai/2019-11-SharedSecret
...
Alternative: Passing custom hash functions to ECDH
2019-12-09 21:11:30 +00:00
5619f2a5df
Add an unsafe variant of new_with_has called new_with_hash_no_panic
2019-12-09 22:53:24 +02:00
124c1f3c7c
feature gate new_with_hash with std only, added catch_unwind
2019-12-05 18:05:40 +02:00
d2c4e5a846
Wrap Secp256k1 from raw context in a ManuallyDrop
2019-12-05 17:51:59 +02:00
f80428258c
Add tests for the new SharedSecret::new_with_hash() function
2019-12-05 17:46:24 +02:00
af8fa21a20
Add 'new_with_hash' function to SharedSecret
2019-12-05 17:46:23 +02:00
9759cb07f5
Replace SharedSecret with a more generic alternative
2019-12-05 17:45:24 +02:00
724c49fff9
Add secp256k1-sys
2019-11-27 21:02:42 +00:00
02f66177f0
Merge pull request #179 from elichai/2019-11-raw-context
...
Creating context from raw pointer
2019-11-27 20:34:43 +00:00
9523e093c1
Add tests for raw context
2019-11-27 22:05:27 +02:00
5f8096e8a8
Add functions to create from raw context
2019-11-27 22:05:23 +02:00
cf22f60919
Merge pull request #162 from elichai/2019-09-ffi
...
Fixes and tests for the ffi
2019-11-27 20:01:17 +00:00
1e711f194c
Merge pull request #184 from elichai/2019-11-context
...
Fix a safety problem and make the Context trait unimplementable
2019-11-27 19:58:44 +00:00
9522f7e4a4
Make Context::deallocate unsafe fn
2019-11-27 17:42:01 +02:00
fe688ada65
Make the Context trait unimplementable
2019-11-27 17:36:06 +02:00
47b2555e80
Merge pull request #182 from rodoufu/code_imp
...
Updating libraries and small code improvements
2019-11-22 16:02:33 +00:00
1b0c57377a
Remove trailing whitespace
2019-11-20 20:36:18 +01:00
825493bea9
Small code improvements.
2019-11-17 22:10:40 -03:00
a4ccab7431
Libraries.
2019-11-17 22:04:11 -03:00
d900dcd1c9
Merge pull request #177 from elichai/2019-10-csymbols
...
Add a feature to disable replacing C symbols with rust
2019-10-29 01:39:08 +00:00
349b2eac06
Add a 'dont_replace_c_symbols' feature for not replacing C's symbols with rust. isn't compatible with no-std
2019-10-28 23:05:38 +02:00
f09ff2a9de
Disable some useless lints
2019-10-28 15:20:04 -04:00
06b2bebce8
Add a test for the types
2019-09-14 22:59:36 +03:00
5b10d1b226
Fix bad ffi declarations
2019-09-14 21:12:59 +03:00
eddfe03dbc
Merge pull request #151 from elichai/2019-08-Cptr-null
...
Explicit checks for ZST + null fallbacks
2019-08-21 23:03:30 +00:00
d7461e4cdc
Add zst tests and some other parsing tests
2019-08-21 18:06:02 -04:00
ddb8e4fdf2
Explicit checks for empty slices
2019-08-21 13:09:36 -04:00
b7e20c5b12
Changed all as_*ptr() to the safer CPtr trait
2019-08-21 13:09:36 -04:00
66ab70f991
Added a C Ptr trait that returns a null pointer for ZSTs
2019-08-21 13:09:20 -04:00
255d1ddd60
Remove TODOs for ffi functions for setting secp256k1 callbacks
...
We would not want to use these functions internally because we rely on
USE_EXTERNAL_DEFAULT_CALLBACKS to provide the callbacks at link time,
see f7a4a7ef57
2019-08-20 14:47:33 +02:00
8e701b75b2
Replacing usage of the unsafe `blank` function to the `new` function
...
Signed-off-by: Elichai Turkel <elichai.turkel@gmail.com>
2019-08-16 14:15:31 -04:00
389e1e2449
Removing usage of `mem::uninitialized()` and deprecating the `blank()` functions
...
Signed-off-by: Elichai Turkel <elichai.turkel@gmail.com>
2019-08-16 14:15:27 -04:00
16fc4ee3fc
Fixed the counter Rng
2019-08-13 10:41:39 -04:00
0f25474805
Implement hex human-readable serde for PublicKey
2019-07-23 17:50:56 +02:00
ccac3ead25
Implement fmt::LowerHex for SecretKey and PublicKey
2019-07-23 17:50:54 +02:00
7356705b61
Added a test for create/destroy functions
2019-07-14 16:35:51 -04:00
75784ec26f
Implemented context create/destroy in rust
2019-07-14 16:35:47 -04:00
96ca40faed
Exposed generic functions to create the Context
2019-07-04 21:36:32 -04:00
49f0cc1c46
Updated the fuzzing dummy functions
2019-07-04 19:13:26 -04:00
811e8d24e9
Removed context_create/destroy/clone and scratch_create/destroy/clone functions.
2019-07-04 19:09:04 -04:00
9186f0223a
Added preallocation size functions and added a test for the preallocation
2019-07-04 18:40:08 -04:00
1c0ae7d4ba
Added structs and functions for manual allocation
2019-07-04 18:40:07 -04:00
b4b52a9858
Moved the context specific traits/enums into a separate file with `std` gate
2019-07-04 18:40:07 -04:00
5f93474512
Added the preallocated FFI
2019-07-04 18:40:04 -04:00
68c5c5edbf
implemented strlen to deref the callback message
2019-07-03 17:50:16 -04:00
8022757681
Added a c_char implementation
2019-07-03 17:48:35 -04:00
f7a4a7ef57
Added manual external callbacks that panics
2019-07-03 17:48:35 -04:00
0e6ff34009
Fix imports when using recovery with fuzztarget feature
2019-05-29 00:02:11 +00:00
be457afdae
Removed ffi call from Display implementation
2019-05-21 22:05:18 +03:00
0bf88fe444
Merge pull request #109 from jonasnick/human-sigs
...
Add human readable serialization to Signatures
2019-05-21 17:50:41 +00:00
ebf50df1d1
Add human readable serialization to Signatures
2019-05-21 10:34:18 +00:00
28934ab5a7
Only display existing signature bytes
2019-05-21 10:22:05 +00:00
16da1a854c
Move recovery ffi into recovery module and feature gate C-secp recovery module
2019-05-21 07:52:08 +00:00
c7eecd159e
Feature gate recovery module
2019-05-21 07:02:11 +00:00
264b368ee0
Move recovery to its own module
2019-05-20 19:11:59 +00:00
3825ed35a7
Add human readable serialization and deserialization to Secret Key
2019-05-14 11:15:18 +00:00
ab4320f8cc
Merge pull request #100 from elichai/master
...
Add no-std support
2019-05-10 23:32:52 +02:00
dfcf74f9d0
Added a new struct for the DER serialized signature
2019-05-11 00:11:42 +03:00
90faf434c9
Merge pull request #104 from alekseysidorov/fix_rand
...
Fix `Rand` trait bounds.
2019-05-01 01:47:43 +00:00
312b9a55fc
Added Error::description copied c_void impl from core::ffi::c_void
2019-04-30 22:07:27 +03:00
91c43e7320
Add as_mut_ptr to PublicKey
2019-04-16 18:48:24 +00:00
2536c5a3c4
Fix rand trait bounds.
2019-04-16 16:35:33 +03:00
e98975a1c0
Added backwards support without the crate keyword
2019-04-14 12:09:43 +03:00
ab8066eb1a
Replaced the std::os::raw c types with types.rs
2019-04-14 12:09:42 +03:00
11ce86681f
Replaced std with core, and made std::error::Error optional through feature
2019-04-14 12:09:36 +03:00
6eaacb19c5
Add raw context getter to Secp256k1 struct
2019-03-01 19:39:55 +00:00
a8a3afe8db
Fix clippy errors
...
Changes include cargo-fix generated, Default impls
2019-02-25 20:12:25 -08:00
bafef68c56
Bumps rand to 0.6.3 & associated updates
2019-02-25 20:09:43 -08:00
f90e9f3454
Stop checking context flags for secp256k1_ecdh as its not required
2019-01-16 16:02:24 -05:00
a74cbb6781
Sync fuzztarget combine with tweak_add since real functions do that
...
Some new fuzz tests I was writing ended up failing because two
nodes came up with different keys because adding public keys and
adding a tweak to a private key and multiplying by the generator
should get the same thing.
2019-01-08 16:12:40 -05:00
9c45944a5f
Remove dependency on libc
2018-12-27 14:39:54 +01:00
b470f70e90
Merge pull request #57 from rust-bitcoin/2018-08-no-index
...
remove `ops::Index` impls for `Signature`
2018-12-03 14:27:08 +01:00
e5a02bd9a0
add `ThirtyTwoByteHash` hash trait which can be implemented for easier conversion of things to `Message`s
2018-11-10 13:12:10 +00:00
1f4a4c11a3
change add_*_assign and mul_*_assign to use a byteslice as a tweak, rather than a `SecretKey`
...
This makes more conceptual sense and does not add any new error paths, since even
valid `SecretKey`s were able to be invalid tweaks.
2018-11-10 13:08:18 +00:00
f93b959b4a
disallow Messages that are not valid secret keys to prevent mistakes related to 0
2018-11-10 13:05:11 +00:00
8d2347602a
remove `ops::Index` impls for `Signature`
2018-11-10 12:56:19 +00:00
7fbaf2f91b
remove unsafe ZERO_KEY and deprecated ONE
2018-11-10 12:56:19 +00:00
4b88cfc2fc
Merge pull request #78 from rust-bitcoin/2018-11-remove-without-caps
...
Update upstream libsecp; remove `without_caps` and all use of dummy contexts
2018-11-10 12:51:14 +00:00
8986aa3d71
export `serde`, `rand` and `libc`; update version to 0.11.5
2018-11-07 20:18:55 +00:00
223eb41fd0
remove context object from ECDH
2018-11-06 22:16:24 +00:00
93abca5896
remove `without_caps` and every function that used a cap-less context
2018-11-06 22:16:24 +00:00
4653100b7a
update upstream libsecp256k1 to 314a61d72474aa29ff4afba8472553ad91d88e9d
2018-11-06 22:16:13 +00:00
68c838f357
change `Debug` impl for `Signature` to use `Display`
2018-11-03 15:52:07 +00:00
30aa3a0c28
add `fmt::Display` and `str::FromStr` impls for `Signature`
2018-11-03 15:52:05 +00:00
572adb2873
add `FromStr` implementation for key types
2018-11-03 15:52:03 +00:00
a810880c54
restore missing `mem` import in key.rs
2018-08-22 20:43:20 +00:00
0d41c23c21
Revert "remove PublicKey::combine"
...
This reverts commit 17450e91fd
2018-08-22 20:18:25 +00:00
c773dfbc8d
remove unused import that was causing warning
2018-08-22 16:40:05 +00:00
2c18a16858
Merge pull request #50 from rust-bitcoin/2018-08-no-combine
...
remove PublicKey::combine
2018-08-21 18:36:27 +00:00
3563c5f305
Merge pull request #46 from rust-bitcoin/2018-08-context-debug
...
add Debug impl to context object
2018-08-20 18:34:13 +00:00
1f73a784cb
Merge pull request #52 from rust-bitcoin/2018-08-display-keys
...
add Display impl for the key types which outputs their hex representation
2018-08-20 18:32:53 +00:00
7a5617d01d
Merge pull request #44 from rust-bitcoin/2018-07-docs
...
improve documentation
2018-08-20 18:12:42 +00:00
93d8249028
improve documentation
2018-08-20 17:56:46 +00:00
7d2474b10a
add Display impl for the key types which outputs their hex representation
...
Since making PublicKey::serialize return a fixed-size array, this no longer
requires any allocation, so there's no reason not to have it.
2018-08-15 20:40:15 +00:00
17450e91fd
remove PublicKey::combine
2018-08-15 16:29:23 +00:00
5c6dcf6b5e
Fix typo
2018-08-15 11:03:22 +03:00
83c7b6d9b7
add Debug impl to context object
2018-08-12 15:23:05 +00:00
2478930ec1
add feature-gated serde 1.0 support for Signature, SecretKey, PublicKey
2018-07-25 14:44:51 +00:00
54ddbc74a4
Merge pull request #37 from rust-bitcoin/2018-07-public-key
...
remove `PublicKey::new()` and `PublicKey::is_valid()`
2018-07-25 13:19:10 +00:00
c3ec027925
remove `PublicKey::new()` and `PublicKey::is_valid()`
2018-07-24 21:24:19 +00:00
bc773fbdce
add comments for Sync/Send impl
2018-07-24 21:18:03 +00:00
2aeff4c62f
fix typos
2018-07-24 21:16:52 +00:00
5442e710a8
Remove Schnorr support
...
It was removed from bitcoin-core/libsecp256k1 at e06e878fd7dcc99825025fa99aedb86bc7d5c29f
2018-07-09 15:10:38 +03:00
b433e7bb1e
Merge pull request #27 from thomaseizinger/feature/ergonomic-apis
...
Improve API ergonomics
2018-06-08 18:02:24 +00:00
20222d50c9
Add docs to new public API
2018-06-08 08:48:28 +08:00
f13cdfa8a4
Replace Result return type with actual value
...
This introduces the actual breaking API change.
2018-06-08 08:48:02 +08:00
be7134c7f4
Cleanup obsolete code
...
Remove ContextFlag enum
Remove InvalidContext error-enum variant
Remove unused imports
2018-06-08 08:41:30 +08:00
bb77741e47
Fix unit tests and benchmarks
...
The new API allows us to remove a bunch of tests which are now checked
by the compiler.
2018-06-08 08:38:06 +08:00
f1a88259fb
Introduce generic-based capability handling
...
Add type parameter to Secp256k1
Add PhantomData for C
Separate into structs and traits
Move constructors to own impl blocks
2018-06-06 12:58:29 +08:00
94807d9d29
Merge pull request #24 from TheBlueMatt/master
...
impl fuzztarget secp256k1_ecdsa_signature_serialize_der
2018-06-04 18:46:58 +00:00
113fe420b9
Add tests to detect regressions.
2018-05-31 13:05:43 +03:00
b192157ab4
Implement Ord for arrays
2018-05-22 12:33:11 +03:00
207ccdf803
impl fuzztarget secp256k1_ecdsa_signature_serialize_der
2018-04-25 13:11:15 -04:00
730da80f0b
Ensure fuzztarget pubkey deserialize-serialize roundtrips are same
2018-03-29 15:41:28 -04:00
eee25f6265
Fix fuzztarget ECDH to be symmetric
2018-03-29 11:21:13 -04:00
e1878c4522
Remove all serde/rustc-serialize stuff
2018-03-21 18:01:33 -04:00
86af2dc0d2
Fix missing include on older rustcs
2018-03-21 18:01:33 -04:00
5a7c88b9c7
Add fuzztarget feature that replaces crypto with memcpys
2018-03-20 11:58:59 -04:00
7b396112fd
Correct ptr type in ffi
2018-03-19 15:49:16 -04:00
6d4f64f901
fix potential unsafety bug for non-u8 types in macros
...
We don't have any non-u8 newtypes but better safe than sorry. See
https://github.com/apoelstra/rust-bitcoin/pull/45/
2018-02-14 16:25:45 +00:00
f14e747431
expose key::{Secret, Public}Key in the crate root for ease of use
2018-01-17 15:38:11 +00:00
2c5f45e165
expose 2-key version of PublicKey::combine
2017-12-21 01:04:07 +00:00
5c54698bf9
make `serde` optional
2017-12-19 22:40:06 +00:00
12e9f4b90b
make `rustc-serialize` crate optional
2017-12-19 22:36:30 +00:00
298929600b
make `rand` crate optional
2017-12-19 22:36:27 +00:00
dba0d67912
remove arrayvec dependency; rename PublicKey::serialize_vec
2017-12-19 20:36:46 +00:00
e71ed3b6d2
Implement serde traits for Signature
2017-07-21 23:58:19 +02:00
b1d8b09f25
Add tests for trailing bytes during deserilization
2017-07-21 22:21:37 +02:00
76d160344b
Update serde to 1.0
2017-07-21 22:15:00 +02:00
b6887b44a0
add compact signature encoding
2017-07-12 19:55:06 +00:00
f88eb1d6d7
Merge pull request #14 from petertodd/2017-05-08-use-copy_from_slice
...
Use safe copy_from_slice() rather than unsafe copy_nonoverlapping()
2017-05-08 12:53:19 +00:00
20c5b903db
Replace unsafe copy_nonoverlapping() with safe copy_from_slice()
2017-05-08 07:31:08 -04:00
eccd625828
Implement From<[u8;32]> for Message
2017-05-08 07:10:51 -04:00
70fd5a9e27
Improve Error::InvalidMessage comment
2017-05-08 06:12:25 -04:00
ab0493e46a
Use DefaultHasher in place of the deprecated SipHasher
2017-04-27 21:46:28 +02:00
5b906ec069
expose *_tweak_mul functions
2016-08-20 17:00:39 +00:00
9e3b93d572
Add ZERO_KEY and ONE_KEY constants
...
Turns out you cannot initialize constant SecretKeys in any way; these
two constants should cover most sane use cases (other good choices
are the SECG generator and the Alpha CT generator, but these will
wait for a major CT-supporting upgrade, unless demand for them appears.)
2016-08-07 21:33:38 +00:00
458a3d9417
Update libsecp to latest master, c18b869e58aa4d3bff6958f370f6b643d1223c44
2016-01-14 18:35:54 +00:00
16b36f18e1
key: Add PubKey hashing test.
2016-01-08 20:04:10 -08:00
6686c213dd
Implement Hash for PublicKey.
2016-01-05 21:01:40 -08:00
cfde1f9925
Add missing schnorr.rs
2015-12-20 13:47:53 -06:00
4f83a83308
cleanup: remove unused attributes; add `dev` compile feature that'll run clippy
2015-12-19 20:20:47 -06:00
f613dbbc00
Fix nonce doccoments
2015-12-15 12:48:01 -06:00
8aa2569818
Expose Schnorr sign/verify
2015-12-15 12:47:07 -06:00
9a91b69fad
Remove side-effect from assertion; add release build to travis
2015-11-18 18:22:16 -06:00
d35168d626
[BREAKING CHANGE] Fix FFI
2015-11-15 17:00:07 -06:00
2df3c0b37c
Minor changes for problems `cargo clippy` found
2015-10-28 07:48:28 -05:00
a65f4cf01f
Expose normalize_s function to convert signatures to low-S form
2015-10-26 14:25:18 -05:00
8e984c5912
Add "lax DER" support; bump major version number for recent build system changes
2015-10-26 12:59:40 -05:00
e7ca836c2b
Switch to static linking of secp256k1
...
Pieter moved some stuff I need into the contrib/ directory which does
not expose anything through the shared lib, so I need to statically
link.
I might also use this to do evil things to expose the SHA256 code
in libsecp, but not for now ;).
2015-10-26 10:28:01 -05:00
f1e1da1213
Update for breaking changes in underlying rustc.
...
This should be a major version number since I changed public constants
in the ffi module. I'm not doing so as the invariant "will the constants
be meaningful to the underlying library" has not changed.
In general this library's version numbers do not map well to the
underlying library, which is as-yet not versioned at all, so users
need to always be running "the lastest" rust-secp256k1 anyway, and
semantic versioning can't really be used meaninfully. So this is a
bit of a judgement call.
2015-10-25 18:26:08 -05:00
d49db8167e
impl Error for error type; remove `Unknown` error variant
2015-10-17 09:49:19 -05:00
32107132f0
Improve unit tests for bad secp context
2015-10-14 12:21:15 -05:00
c84cfb193f
[BREAKING CHANGE] Make PK::from_secret_key() return a Result; change from_ffi functions to From impls
...
If you try to call PublicKey::from_secret() key with an incapable context it will
now return an error. Before it would pass through to the underlying library which
would terminate the process, something we strive to never expose.
Also change the from_ffi functions on various types to impl's of From to be more
Rustic. We cannot change the from_slice functions because they have error returns.
Also add a Secp256k1::without_caps() function which creates a capability-less
context. I find myself using this in so many places downstream that it seems
appropriate.
2015-10-14 09:38:43 -05:00
595f64bca6
Adding to_i32 and from_i32 functions to RecoveryId in order to give
...
library users the ability to create RecoveryId objects and convert them to i32 equivalents, without allowing users to create invalid ones.
2015-10-11 15:24:44 -07:00
ebde999634
RecoverableSignature now supports compact serialization via FFI, with additional test case added.
2015-10-11 00:04:28 -07:00
701c5e5e08
Expose serialization of Signature; move copy_nonoverlapping for rustc stable
2015-10-09 14:20:21 -05:00
ec0e8407f2
Minor documentation fixes
2015-10-09 11:39:42 -05:00
2748dae7eb
Remove `hex_slice` macro as it was never used
2015-09-21 08:30:06 -05:00
b978e76934
Drop some unused imports; bump version no
2015-09-20 15:30:43 -05:00
5ce825398a
Fix benchmarks
2015-09-20 15:24:25 -05:00
b42b1f9408
Bugfix for nightly
2015-09-20 15:13:42 -05:00
4012281a2d
Fix for upstream API changes
2015-09-20 14:52:29 -05:00
cc68cf8b9e
Update serde dep to 0.6 from 0.3
2015-09-20 13:29:09 -05:00
016d781f2e
Fix for upstream API changes; add ECDH support
...
I didn't mean for both of these to go into the same commit, but given how
small the ECDH code was, and the fact that no commit prior to this one will
compile (as both libsecp256k1 and rustc have changed so much), I'm letting
it slide.
2015-09-18 15:40:42 -05:00
8d6f384dac
Update Travis to use travis-cargo
2015-07-28 13:21:12 -05:00
77f6b6bf21
[API BREAK] Update for new libsecp256k1 API
2015-07-28 11:05:13 -05:00
5602d6f988
Expose `secp256k1_context_randomize`
...
This is a new libsecp256k1 function which does additive blinding
for nonce generation during signing.
2015-05-03 18:22:30 -05:00
63011aaa3f
Add a bunch of benchmarks
2015-04-30 14:28:34 -05:00
fba427cb15
Add extreme value sign/verify test
2015-04-28 13:46:17 -05:00
1ba1f5b2ce
Add sanity-check unit test for RecoveryId
...
This is kinda silly but gets me 100% coverage from kcov
2015-04-13 22:21:56 -05:00
f8bbc89df6
[API BREAK] expose ability to create contexts without verify or signing caps
...
There are a lot of cases in rust-bitcoin where we need a `Secp256k1`
which doesn't need any signing or verification capabilities, only
checking the validity of various objects. We can get away with a bare
context (i.e. no precomputation) which can be cheaply created on demand,
avoiding the need to pass around references to Secp256k1 objects everywhere.
API break because the following functions can now fail (given an insufficiently
capable context) and therefore now return a Result:
Secp256k1::generate_keypair
Secp256k1::sign
Secp256k1::sign_compact
2015-04-13 22:15:52 -05:00
d7c7230f28
Impl `Send` and `Sync` for secp256k1 contexts
2015-04-13 20:41:24 -05:00
fb75373b47
[API BREAK] Remove Rng from Secp256k1 and associated code
...
The Rng was only used for key generation, and for BIP32 users not even then;
thus hauling around a Rng is a waste of space in addition to causing a
massive amount of syntactic noise. For example rust-bitcoin almost always
uses `()` as the Rng; having `Secp256k1` default to a `Secp256k1<Fortuna>`
then means even more syntactic noise, rather than less.
Now key generation functions take a Rng as a parameter, and the rest can
forget about having a Rng. This also means that the Secp256k1 context
never needs a mutable reference and can be easily put into an Arc if so
desired.
2015-04-12 15:54:22 -05:00
83823379e4
[minor API BREAK] Add unit tests to cover all error cases
...
This comes with a couple bugfixes and the following API changes:
- Secp256k1::sign and ::sign_compact no longer return Result;
it is impossible to trigger their failure modes with safe
code since the `Message` and `SecretKey` types validate when
they are created.
- constants::MAX_COMPACT_SIGNATURE_SIZE loses the MAX_; signatures
are always constant size
- the Debug output for everything is now hex-encoded rather than
being a list of base-10 ints. It's just easier to read this way.
kcov v26 now reports 100% test coverage; however, this does not
guarantee that test coverage is actually complete. Patches are
always welcome for improved unit tests.
2015-04-12 10:51:15 -05:00
9a01401746
Add missing implementations; update FFI for libsecp256k1's new cloning fn
2015-04-12 09:36:49 -05:00
edab2568d2
Change `Secp256k1::with_rng` to not return a Result
...
This function can't fail, so no need to return a Result.
2015-04-11 19:13:39 -05:00
6b39f97f51
Add `Secp256k1::new_deterministic` constructor for applications which don't need randomness
2015-04-11 13:28:15 -05:00
96e1844c25
Change inline assertions to debug_asserts
...
All of these were things that are (should be) guaranteed true no matter
what input is given to the API, barring unsafe operations on the data.
2015-04-11 13:07:43 -05:00
9e717d4219
Add `Secp256k1::with_rng`, parameterize `Secp256k1` over its RNG.
...
Now that you can't create secret keys by directly passing a Rng to
`SecretKey::new`, we need a way to allow user-chosed randomness.
We add it to the `Secp256k1`.
2015-04-11 12:53:30 -05:00
e52faee98f
[API BREAK] update for libsecp256k1 "explicit context" API break
...
Rather than have global initialization functions, which required
expensive synchronization on the part of the Rust library,
libsecp256k1 now carries its context in thread-local data which
must be passed to every function.
What this means for the rust-secp256k1 API is:
- Most functions on `PublicKey` and `SecretKey` now require a
`Secp256k1` to be given to them.
- `Secp256k1::verify` and `::verify_raw` now take a `&self`
- `SecretKey::new` now takes a `Secp256k1` rather than a Rng; a
future commit will allow specifying the Rng in the `Secp256k1`
so that functionality is not lost.
- The FFI functions have all changed to take a context argument
- `secp256k1::init()` is gone, as is the dependency on std::sync
- There is a `ffi::Context` type which must be handled carefully
by anyone using it directly (hopefully nobody :))
2015-04-11 12:52:54 -05:00
609f658bee
[API BREAK] Remove `Sequence` iterator over secret keys
...
Y'know, I can't for the life of me think what this was supposed to
be used for. Given that the library did not compile for several
months until last week, I assume there are no users, let alone
users of such a weird feature.
2015-04-11 12:24:04 -05:00
ac61baf040
Add support for serde (de)serialization; add unit tests
2015-04-10 00:32:12 -05:00
1b2858bc8a
Rename secp256k1.rs to lib.rs
2015-04-09 10:35:38 -05:00
1591bba3f9
Update bindings to current secp256k1 library
...
rust-secp256k1 was based off of https://github.com/sipa/secp256k1 ,
which has been inactive nearly as long as this repository (prior to
a couple days ago anyway). The correct repository is
https://github.com/bitcoin/secp256k1
This is a major breaking change to the library for one reason: there
are no longer any Nonce types in the safe interface. The signing functions
do not take a nonce; this is generated internally.
This also means that I was able to drop all my RFC6979 code, since
libsecp256k1 has its own implementation.
If you need to generate your own nonces, you need to create an unsafe
function of type `ffi::NonceFn`, then pass it to the appropriate
functions in the `ffi` module. There is no safe interface for doing
this, deliberately: there is basically no need to directly fiddle
with nonces ever.
2015-04-06 00:13:38 -05:00
f6585616b1
Add `Display` impl to `Error`; cleanup `Result` mess
2015-04-05 20:27:43 -05:00
5b3858e0ce
Simplify Index implementations
2015-04-05 12:16:56 -05:00
e2daaf875d
Update for language changes (rustc beta is out !!)
2015-04-04 12:20:38 -05:00
abc5b865e7
Change rustc-serialize for crate hyphen transition
2015-03-26 10:07:28 -05:00
16b6dc73ca
`Cargo test` now builds and passes locally :)
2015-03-25 20:55:01 -05:00
42dfa752ce
More slicing
2015-03-25 20:52:09 -05:00
ec6aea7ca1
Fiddle with crates, `cargo build` now succeeds :)
2015-03-25 20:44:04 -05:00
d858d7f7e6
Slicing fixes
2015-03-25 20:36:57 -05:00
f910355043
Change rand crate to crates.io version
2015-03-25 18:57:16 -05:00
7bd24615f6
Change std::rand to just rand::, though there is still a 'unimplemented trait' error :/
2015-03-25 18:22:24 -05:00
d2fcbbe95a
Change name to secp256k1 from bitcoin-secp256k1-rs
...
[breaking-change]
2015-03-25 17:20:44 -05:00
825e77519f
for in range(a,b) -> for in a..b
2015-03-25 14:42:05 -05:00
d0519f0b3a
IoResult -> io::Result, copy_nonoverlapping_memory -> copy_nonoverlapping
2015-03-25 14:10:02 -05:00
1e24549ef5
Show -> Debug
2015-03-25 13:59:54 -05:00
5a6c6c8d0a
Fix for secp256k1 ffi changes
...
All tests pass, compile now
2015-01-17 10:38:16 -06:00
d495d9ca06
Update for rustc changes
...
We can compile now, but not link -- there have been too many changes
in libsecp256k1 behind the scenes. Next commit :)
2015-01-17 10:13:45 -06:00
9cab4e023d
Revert "Overhaul interface to use zero-on-free SecretKeys"
...
This reverts commit 9889090784
2014-09-12 08:28:35 -05:00
9889090784
Overhaul interface to use zero-on-free SecretKeys
...
Using the `secretdata` library, we can store SecretKeys in such a way
that they cannot be moved or copied, and their memory is zeroed out on
drop. This gives us some assurance that in the case of memory unsafety,
there is not secret key data lying around anywhere that we don't expect.
Unfortunately, it means that we cannot construct secret keys and then
return them, which forces the interface to change a fair bit. I removed
the `generate_keypair` function from Secp256k1, then `generate_nonce`
for symmetry, then dropped the `Secp256k1` struct entirely because it
turned out that none of the remaining functions used the `self` param.
So here we are. I bumped the version number. Sorry about this.
2014-09-12 08:28:26 -05:00
62504165e4
Reimplement non-typesafe `verify` fn, call it `verify_raw`.
...
The typesafe version could not accept illegally padded signatures because
`Signature` is a fixed-width type. Unfortunately such signatures are on
the blockchain, and we need a way to verify them.
2014-09-04 20:32:49 -05:00
eabe57e403
Also make PublicKey encodable
2014-09-04 20:21:09 -05:00
71312b032a
Impl encodable/decodable for the array newtypes
2014-09-04 20:09:18 -05:00
17daebf15d
Implement deterministic nonce generation with HMAC-SHA512
...
Testing was done against python-ecdsa; python code in the test case
comments.
2014-09-04 16:21:35 -05:00
46f646dabb
Make `verify` accept a `Signature` rather than a slice
...
[breaking-change]
2014-09-04 11:52:25 -05:00
770ebbafc4
Add a `Sequence` iterator for generating sequential keypairs; fix tests
2014-09-01 11:13:31 -05:00
204524117c
Make Secp256k1::verify() static
...
This avoids the overhead of creating and seeding a Fortuna just to do verification.
2014-08-31 22:33:19 -05:00
d94345f721
Generate keys from Fortuna rather than always using the OsRng
...
When creating a Secp256k1, we attach a Fortuna CSRNG seeded from the
OS RNG, rather than using the OS RNG all the time. This moves the
potential RNG failure to the creation of the object, rather than at
every single place that keys are generated. It also reduces trust
in the operating system RNG.
This does mean that Secp256k1::new() now returns an IoResult while
the generate_* methods no longer return Results, so this is a breaking
change.
Also add a benchmark for key generation. On my system I get:
test tests::generate_compressed ... bench: 492990 ns/iter (+/- 27981)
test tests::generate_uncompressed ... bench: 495148 ns/iter (+/- 29829)
Contrast the numbers with OsRng:
test tests::generate_compressed ... bench: 66691 ns/iter (+/- 3640)
test tests::generate_uncompressed ... bench: 67148 ns/iter (+/- 3806)
Not too shabby :)
[breaking-change]
2014-08-31 22:26:02 -05:00
059c72aa60
Do validation in pubkey::from_slice
2014-08-31 16:04:14 -05:00
a0ecfe9e29
Change lint names for upstream
2014-08-30 07:24:44 -07:00
15b8183ea8
Remove error return from `PublicKey::from_secret_key()`
...
Make sure that you cannot create an invalid `SecretKey` in the first place.
Unbreaks the API.
[unbreaking-change]
2014-08-28 11:11:25 -07:00
a67260eb3a
Remove unsafe markers and just call `init` everywhere
...
It turns out I need to run `init` before pretty-much every FFI function,
which means that most everything would have to be marked unsafe if I'm
expecting the Rust user to do this. This is unacceptable -- users who
need to sacrifice safety for speed can just use the `ffi::` functions
instead.
Also, I noticed that I was locking up in `PublicKey::from_secret_key`.
Fix to return an error value -- unfortunately a breaking change since
it changes the function signature.
[breaking-change]
2014-08-28 10:59:44 -07:00
a5951eff47
Expose tweak functions in FFI, wrap a couple
2014-08-28 09:16:53 -07:00
e13b23d720
Add curve order and generator coordinates to constants
2014-08-27 22:49:22 -07:00
a0f11d0f92
Travis speaks rust now :D
2014-08-27 10:58:24 -07:00
83f2ccf5d7
Add verification to SecretKey::from_slice()
2014-08-24 16:13:08 -07:00
79815e225b
Add .travis.yml, update tests and Cargo.toml for upstream changes
2014-08-17 18:58:20 -07:00
1ce6e3fd3b
Simpler `random_32_bytes`.
2014-08-16 02:21:35 -07:00
6c8a72ba5d
Remove allocations for Signature, use array instead
...
As @dpc observes, embedded systems do not necessarily have allocators, so we
should avoid using them if it is not too much hassle. (And it is no hassle at
all.)
2014-08-15 23:43:40 -07:00
db37829904
Add CC0 license and header to all files
2014-08-11 19:26:45 -07:00
4be48ecb1b
Move Rng failure from `Secp256k1::new` to functions that actually use randomness
...
Verifying signatures does not require any randomness, but requires the user
to create a `Secp256k1` object nonetheless (this is just a way to guarantee
that `init` is called --- an alternate API would be to have an independent
unsafe `verify` function). If a Rng can't be created, rather than failing
the `Secp256k1` initialization, fail the functions that actually try to use
the Rng.
This way signing and verifying, which require no randomness beyond that input
to them, will work correctly.
To avoid checking for a working Rng on each call to `generate_keypair` and
`generate_nonce` (which is probably trivial next to the cost of actually
generating the randomness, but w/e, user knows best), the user should use
the generation functions in the `key` module, which take an Rng as input.
2014-08-11 19:24:19 -07:00
d6bf4039bd
Pull out initialization code so that `PublicKey::from_secret_key` can be used safely
2014-08-11 19:24:19 -07:00
522bafe433
Remove VerifyResult since it is never used
2014-08-11 19:24:19 -07:00
80df78c9a9
Add slice methods to `Nonce`
2014-08-11 19:24:19 -07:00
0adc7e1ce2
Add keypair slice methods and unit tests
2014-08-11 19:24:19 -07:00
5b15918a9a
Move FFI and constants into their own modules; replace outptrs with returns
2014-08-11 19:24:19 -07:00
448f4829e7
Move FFI functions into separate module; add documentation and style lints
2014-08-11 19:24:19 -07:00
2fa6a4d38e
fix unused import warning
2014-08-04 19:58:57 -04:00
100fc277a6
Fix tests cases.
...
The way compact signatures are working was explain to me:
https://github.com/bitcoin/secp256k1/issues/45
2014-08-04 16:51:47 -07:00
4c9f47e108
Update for newest Cargo
2014-07-23 16:34:04 -07:00
05406515b8
Initial (failing) implementation.
2014-07-06 22:41:22 -07:00
Andrew Poelstra
Tibo-lg
Tobin Harding
Thomas Eizinger
Elichai Turkel
Justin Moon
Sebastian Geisler
Kohei Taniguchi
Kirill Fomichev
Matt Corallo
Wei Tang
Steven Roose
Tony Jin
Rodolfo Araujo
Tim Ruffing
Jonas Nick
Aleksei Sidorov
François Garillot
Pierre Krieger
Tim Ruffing
Dimitris Apostolou
Roman Zeyde
Peter Todd
Christian Nyumbayire
Dawid Ciężarkiewicz
Matt Quinn
Dawid Ciężarkiewicz
Steve Klabnik