rust-secp256k1-unsafe-fast/src
Andrew Poelstra ab9fdf006c
Merge rust-bitcoin/rust-secp256k1#510: Fix incorrect method call
cd7a6b316b Fix incorrect method call (Tobin C. Harding)

Pull request description:

  We have the following method on `SecretKey`

  ```
      pub fn sign_ecdsa(&self, msg: Message) -> ecdsa::Signature {
          SECP256K1.sign_ecdsa(&msg, self)
      }
  ```

  But we have a method call in rustdocs
  ```
  //! let (secret_key, public_key) = generate_keypair(&mut thread_rng());
  //! let message = Message::from_hashed_data::<sha256::Hash>("Hello World!".as_bytes());
  //!
  //! let sig = secret_key.sign_ecdsa(&message, &secret_key);
  ```

  This is incorrect, I have no idea why this code builds.

  (Also see https://github.com/rust-bitcoin/rust-secp256k1/issues/508.)

ACKs for top commit:
  apoelstra:
    ACK cd7a6b316b

Tree-SHA512: 5f22157798a4e4a21fff946dd930c62c7d82100a8e729309f6383709cb3fefdd935df1b7954fc545f1c2283a46b8c22f61e1c6d4534cb750eb7ab3b5036eedf5
2022-11-16 18:10:50 +00:00
..
ecdsa Merge rust-bitcoin/rust-secp256k1#507: Minimise FFI in the public API 2022-11-14 14:13:22 +00:00
constants.rs Remove deprecated code 2022-11-10 11:30:40 +11:00
context.rs Remove cfg docs feature requirements 2022-11-15 12:14:29 +11:00
ecdh.rs Merge rust-bitcoin/rust-secp256k1#509: Improve feature usage bitcoin-hashes[-std] 2022-11-14 14:19:57 +00:00
key.rs Remove ONE_KEY 2022-11-15 12:14:29 +11:00
lib.rs Fix incorrect method call 2022-11-15 12:25:31 +11:00
macros.rs Improve Error display 2022-06-14 09:33:48 +10:00
scalar.rs Add array constants 2022-11-06 05:21:16 +11:00
schnorr.rs Merge rust-bitcoin/rust-secp256k1#507: Minimise FFI in the public API 2022-11-14 14:13:22 +00:00
secret.rs Remove ONE_KEY 2022-11-15 12:14:29 +11:00
serde_util.rs Use fixed width serde impls for keys 2022-06-09 16:09:31 +10:00