add aliases for solana workflow generate-nonce-account

crates/icepick-workflow/src/lib.rs

@@ -51,7 +51,7 @@ impl Input {
     }
 
     pub fn is_required(&self) -> bool {
-        self.optional.is_some_and(|o| o)
+        self.optional.is_some_and(|o| !o)
     }
 }
 

crates/icepick/src/cli/workflow.rs

@@ -95,25 +95,22 @@ pub fn generate_command(workflow: &Workflow) -> clap::Command {
     // NOTE: all required inputs are still marked as .required(false) since they could be included
     // in the `--input-file` argument.
     for input in workflow.inputs.iter() {
-        for arg in input.identifiers() {
+        let name = &input.name;
-            let arg = clap::Arg::new(arg)
+        let arg = clap::Arg::new(name)
-                .required(false)
+            .required(false)
-                .help(&input.description)
+            .help(&input.description)
-                .long(arg.replace('_', "-"))
+            .long(name.replace('_', "-"))
-                .value_name(arg.to_uppercase())
+            .value_name(name.to_uppercase())
-                .conflicts_with_all(
+            .visible_aliases(&input.aliases);
-                    input
+        command = command.arg(arg);
-                        .identifiers()
-                        .filter(|name| *name != arg)
-                        .collect::<Vec<_>>(),
-                );
-            command = command.arg(arg);
-        }
     }
-    command.arg(clap::arg!(
+    command.arg(
-        --"input-file" [FILE]
+        clap::arg!(
-        "A file containing any inputs not passed on the command line"
+            --"input-file" [FILE]
-    ))
+            "A file containing any inputs not passed on the command line"
+        )
+        .value_parser(clap::value_parser!(std::path::PathBuf)),
+    )
 }
 
 fn load_inputs<'a>(
@@ -127,11 +124,7 @@ fn load_inputs<'a>(
         .and_then(|f| serde_json::from_reader(f).ok());
     for input in inputs {
         let identifier = &input.name;
-        match input
+        match matches.get_one::<String>(&input.name) {
-            .identifiers()
-            .filter_map(|name| matches.get_one::<String>(name))
-            .next()
-        {
             Some(value) => {
                 map.insert(identifier.clone(), value.clone());
                 continue;

crates/icepick/workflows/sol/generate-nonce-account.yaml

@@ -15,6 +15,10 @@ inputs:
     workflows) is required to be a signer of the transaction, so the
     authorization address is often the principal address - the one performing
     the transaction.
+  aliases:
+  - primary_address
+  - principal_address
+  - pubkey
 step:
 - type: "sol-generate-wallet"
 - type: "sol-get-wallet-address"