public
/
keyfork
5
0
Fork 0
Code Issues 16 Pull Requests 1 Packages Projects Releases Wiki Activity

Rewrite keyfork-crossterm into keyfork-multiterm #17

New Issue
Open
opened 2024-01-16 02:37:15 +00:00 by ryan · 0 comments
ryan commented 2024-01-16 02:37:15 +00:00
Owner
Copy Link

Crossterm is built around controlling the existing terminal. This will not be compatible if keyforkd needs to control the terminal of a calling process, or if any program needs to control any terminal other than the terminal provided by the process. Crossterm has a lot of global lock functionality that needs to be replaced with types containing the locked value.

Additionally, Crossterm has a mix of types that implement Command, and functions not associated with Command, in the same modules. Some examples are {Enable,Disable}BracketedPaste in the event module and {Enter,Leave}AlternateScreen in the terminal module. These should be moved to their own module.

Crossterm is built around controlling the existing terminal. This will not be compatible if `keyforkd` needs to control the terminal of a calling process, or if any program needs to control any terminal other than the terminal provided by the process. Crossterm has a lot of global lock functionality that needs to be replaced with types containing the locked value. Additionally, Crossterm has a mix of types that implement `Command`, and functions not associated with `Command`, in the same modules. Some examples are `{Enable,Disable}BracketedPaste` in the `event` module and `{Enter,Leave}AlternateScreen` in the `terminal` module. These should be moved to their own module.
ryan changed title from Investigate how keyfork-crossterm's event::read() works to Rewrite keyfork-crossterm into keyfork-multiterm 2024-01-18 21:21:12 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
ryansquared/staging-since-latest
ryansquared/quick-and-dirty-prompt
ryansquared/keyfork-mnemonic-refactors
ryansquared/bottoms-up
anton/require-min-entropy
anton/chore/update-readme
anton/feat/min_bit_req
ryan/shard-improvements
ryan/harden-derivation-on-highest-level-keys
ryan/use-instant-time-qrcode
stagex-build
ryan/old-static-retain-for-stagex
ryan/recover-shardholder-hardware
ryan/keyfork-prompt/steel
ryan/keyfork-shard/reuse-prompt-handler
ryan/keyfork-shard-reuse-prompt-handler
keyfork-shard-traitify
ryan/fearless-conversions
ryan/optimize-hunk
ryan/cargo-update
ryansquared/keyfork-shard/openpgp-card
keyfork-shard-v0.2.2
keyfork-v0.2.3
keyfork-derive-openpgp-v0.1.2
keyfork-v0.2.2
keyforkd-models-v0.2.0
keyforkd-client-v0.2.0
keyforkd-v0.1.1
keyfork-shard-v0.2.0
keyfork-qrcode-v0.1.1
keyfork-prompt-v0.1.1
keyfork-mnemonic-util-v0.3.0
keyfork-entropy-v0.1.1
keyfork-derive-util-v0.2.0
keyfork-derive-path-data-v0.1.1
keyfork-derive-openpgp-v0.1.1
keyfork-derive-key-v0.1.1
keyfork-v0.2.0
keyfork-v0.1.0
smex-v0.1.0
keyfork-bug-v0.1.0
keyfork-bin-v0.1.0
keyfork-slip10-test-data-v0.1.0
keyfork-derive-util-v0.1.0
keyfork-frame-v0.1.0
keyforkd-models-v0.1.0
keyforkd-client-v0.1.0
keyfork-derive-openpgp-v0.1.0
keyfork-entropy-v0.1.0
keyfork-crossterm-v0.27.1
keyfork-prompt-v0.1.0
keyfork-zbar-sys-v0.1.0
keyfork-zbar-v0.1.0
keyfork-qrcode-v0.1.0
keyfork-shard-v0.1.0
keyfork-derive-path-data-v0.1.0
keyforkd-v0.1.0
keyfork-derive-key-v0.1.0
keyfork-mnemonic-util-v0.2.0
keyfork-mnemonic-util-v0.1.0
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: public/keyfork#17
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?