public
/
website
5
0
Fork 0
Code Issues Pull Requests 3 Packages Projects Releases Wiki Activity

add carousel #4

Manually merged
anton merged 3 commits from carousel into main 2024-03-28 23:21:50 +00:00
Conversation 0 Commits 3 Files Changed 4 +18 -9
3 changed files with 18 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 5b284e2eed - Show all commits

2
_layouts/landing.html
View File

@ -19,7 +19,7 @@
</div>
</div>
<div class="flex-container-inner carousel-container">
<div class="carousel"></div>
<div id="carousel"></div>
<br>
<div style="margin-left: 10px; font-size: 14px">
<a style="color: rgb(73, 73, 73)" href="../assets/js/carousel-items.json">Full list of articles</a>

2
_sass/base.scss
View File

@ -840,7 +840,7 @@ pre {
padding-left: 80px;
}
.carousel {
#carousel {
display: flex;
flex-direction: column;
align-items: center;

17
assets/js/main.js
View File

@ -20,17 +20,26 @@ document.addEventListener('DOMContentLoaded', function () {
});
function createCarouselItems(items) {
const carousel = document.querySelector('.carousel');
const carousel = document.querySelector('#carousel');
anton marked this conversation as resolved Outdated
ryan commented 2023-12-28 03:32:14 +00:00
Outdated
Review
Copy Link

nit: use an id instead of a class

nit: use an id instead of a class
items.forEach(item => {
const itemDiv = document.createElement('div');
itemDiv.className = 'carousel-item';
itemDiv.innerHTML = `<a class="carousel-link" target="_blank" rel="noopener noreferrer" href="${item.link}">${item.description}</a>`;
itemDiv.className = 'carousel-item'
anton marked this conversation as resolved Outdated
ryan commented 2023-12-28 03:33:10 +00:00
Outdated
Review
Copy Link

nit: create the <a> element in code and change the href and innerText manually to avoid XSS

nit: create the `<a>` element in code and change the href and innerText manually to avoid XSS
ryan commented 2023-12-28 03:33:31 +00:00
Outdated
Review
Copy Link

yes we control both the content and the code but it's a good practice to avoid XSS

yes we control both the content and the code but it's a good practice to avoid XSS
const link = document.createElement('a');
link.className = 'carousel-link';
link.href = item.link;
link.target = '_blank';
link.rel = 'noopener noreferrer';
const linkText = document.createTextNode(item.description);
link.appendChild(linkText);
itemDiv.appendChild(link);
carousel.appendChild(itemDiv);
});
}
function initializeCarousel() {
const carousel = document.querySelector('.carousel');
const carousel = document.querySelector('#carousel');
const items = Array.from(carousel.children);
const totalItems = items.length;
const middleIndex = Math.floor(totalItems / 2);