Danny Grove danny
  • Joined on 2024-03-11
danny commented on pull request public/website#7 2024-06-10 16:34:59 +00:00
feat: add blog

Would be good to use the jekyll built-in function for static assets

danny commented on pull request public/website#7 2024-06-10 16:34:23 +00:00
feat: add blog

Doesn't this normally generate files/links in the format blog/:title/index.html?

danny commented on pull request public/website#10 2024-05-17 02:55:05 +00:00
feat: add og tags for nicer previews

Everything that you have hardcoded here should instead be pulled from the config. Here's a jekyll theme that does what you're looking for https://github.com/sujaykundu777/devlopr-jekyll/blob/master/_includes/head.html

danny commented on pull request public/website#10 2024-05-17 02:47:07 +00:00
feat: add og tags for nicer previews

{{ page.title }}

danny commented on pull request public/website#10 2024-05-17 02:46:56 +00:00
feat: add og tags for nicer previews

You'll also need to add the Twitter specific tags

danny commented on pull request public/website#7 2024-04-02 04:40:22 +00:00
feat: add blog

Generally I'd avoid using pulling in the baseurl. This makes local development more difficult and prevents have multiple domains with the same content (eg. deploying as a Tor Hidden Service)

danny commented on pull request public/website#7 2024-04-02 04:40:22 +00:00
feat: add blog

Same here

danny commented on pull request public/website#7 2024-04-02 04:40:22 +00:00
feat: add blog

Please see https://git.distrust.co/public/website/pulls/7/files#issuecomment-385 and apply that to all references of {{ site.baseurl }}

danny commented on pull request public/website#7 2024-04-02 04:40:22 +00:00
feat: add blog

This should use site absolute path

danny commented on pull request public/website#7 2024-04-02 04:40:22 +00:00
feat: add blog

To support more browsers I'd probably do

danny commented on pull request public/website#7 2024-04-02 04:40:22 +00:00
feat: add blog

Absolute path

danny commented on pull request public/website#7 2024-04-02 04:40:22 +00:00
feat: add blog

Absolute path

danny commented on pull request public/website#7 2024-04-02 04:40:22 +00:00
feat: add blog

I'd probably include the title in the link as well