milksad
/
rust-bitcoin-unsafe-fast
14
0
Fork 0
Code Issues Pull Requests Activity

Add byteorder pinning for 1.29.0 compatibility 

They broke their MSRV in a minor release.

Co-authored-by: Sebastian Geisler <sebastian@blockstream.io>
This commit is contained in:
Andrew Poelstra 2021-01-09 16:43:18 +00:00
parent 4b58a254c5
commit ef116ffbed
2 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
README.md
View File

@ -66,6 +66,11 @@ cargo update --package "serde" --precise "1.0.98"
cargo update --package "serde_derive" --precise "1.0.98" cargo update --package "serde_derive" --precise "1.0.98"
``` ```
For the feature `base64` to work with 1.29.0 we also need to pin `byteorder`:
```
cargo update -p byteorder --precise "1.3.4"
```
## Installing Rust ## Installing Rust
Rust can be installed using your package manager of choice or Rust can be installed using your package manager of choice or
[rustup.rs](https://rustup.rs). The former way is considered more secure since [rustup.rs](https://rustup.rs). The former way is considered more secure since

14
contrib/test.sh
View File

@ -2,12 +2,17 @@
FEATURES="base64 bitcoinconsensus use-serde rand" FEATURES="base64 bitcoinconsensus use-serde rand"
# Pin `cc` for Rust 1.29 pin_common_verions() {
if [ -n "$PIN_VERSIONS" ]; then
cargo generate-lockfile --verbose cargo generate-lockfile --verbose
cargo update -p cc --precise "1.0.41" --verbose cargo update -p cc --precise "1.0.41" --verbose
cargo update -p serde --precise "1.0.98" --verbose cargo update -p serde --precise "1.0.98" --verbose
cargo update -p serde_derive --precise "1.0.98" --verbose cargo update -p serde_derive --precise "1.0.98" --verbose
}
# Pin `cc` for Rust 1.29
if [ -n "$PIN_VERSIONS" ]; then
pin_common_verions
cargo update -p byteorder --precise "1.3.4"
fi fi
if [ "$DO_COV" = true ] if [ "$DO_COV" = true ]
@ -58,10 +63,7 @@ then
# Pin `cc` for Rust 1.29 # Pin `cc` for Rust 1.29
if [ -n "$PIN_VERSIONS" ]; then if [ -n "$PIN_VERSIONS" ]; then
cargo generate-lockfile --verbose pin_common_verions
cargo update -p cc --precise "1.0.41" --verbose
cargo update -p serde --precise "1.0.98" --verbose
cargo update -p serde_derive --precise "1.0.98" --verbose
fi fi
cargo test --verbose cargo test --verbose