milksad
/
rust-secp256k1-unsafe-fast
14
0
Fork 0
Code Issues Pull Requests Activity

Borrow secret key 

`SecretKey` implements `Copy` and it is fine to take owneship of it; we
have multiple methods called `from_secret_key` and they all borrow the
secret key parameter. Favour consistency over perfection.

Borrow secret key parameter as is done in other `from_secret_key`
methods.
This commit is contained in:
Tobin Harding 2022-03-24 13:23:12 +11:00
parent e4fb575590
commit c612130864
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/key.rs
View File

@ -674,7 +674,7 @@ impl Ord for PublicKey {
/// ///
/// let secp = Secp256k1::new(); /// let secp = Secp256k1::new();
/// let (secret_key, public_key) = secp.generate_keypair(&mut rand::thread_rng()); /// let (secret_key, public_key) = secp.generate_keypair(&mut rand::thread_rng());
/// let key_pair = KeyPair::from_secret_key(&secp, secret_key); /// let key_pair = KeyPair::from_secret_key(&secp, &secret_key);
/// # } /// # }
/// ``` /// ```
/// [`Deserialize`]: serde::Deserialize /// [`Deserialize`]: serde::Deserialize
@ -706,7 +706,7 @@ impl KeyPair {
#[inline] #[inline]
pub fn from_secret_key<C: Signing>( pub fn from_secret_key<C: Signing>(
secp: &Secp256k1<C>, secp: &Secp256k1<C>,
sk: SecretKey, sk: &SecretKey,
) -> KeyPair { ) -> KeyPair {
unsafe { unsafe {
let mut kp = ffi::KeyPair::new(); let mut kp = ffi::KeyPair::new();
@ -1426,7 +1426,7 @@ pub mod serde_keypair {
Ok(KeyPair::from_secret_key( Ok(KeyPair::from_secret_key(
&::SECP256K1, &::SECP256K1,
secret_key, &secret_key,
)) ))
} }
} }

2
src/secret.rs
View File

@ -160,7 +160,7 @@ impl KeyPair {
/// ///
/// let secp = Secp256k1::new(); /// let secp = Secp256k1::new();
/// let key = ONE_KEY; /// let key = ONE_KEY;
/// let key = KeyPair::from_secret_key(&secp, key); /// let key = KeyPair::from_secret_key(&secp, &key);
/// // Here we explicitly display the secret value: /// // Here we explicitly display the secret value:
/// assert_eq!( /// assert_eq!(
/// "0000000000000000000000000000000000000000000000000000000000000001", /// "0000000000000000000000000000000000000000000000000000000000000001",