public
/
website
5
0
Fork 0
Code Issues 5 Pull Requests 4 Packages Projects Releases Wiki Activity

new-footer #35

Open
xenushka wants to merge 4 commits from new-footer into main
pull from: new-footer
merge into: public:main
Conversation 2 Commits 4 Files Changed 5 +173 -32
xenushka commented 2025-04-20 21:40:41 +00:00
Collaborator
Copy Link
No description provided.
xenushka added 3 commits 2025-04-20 21:40:42 +00:00
xenushka added 1 commit 2025-04-20 21:41:49 +00:00
ryan commented 2025-05-05 20:47:31 +00:00
Owner
Copy Link

I like these changes but I don't think we have enough content in the footer to need the columns. I'm using the Red Hat page's footer (https://www.redhat.com/en) as inspiration on some thoughts: I think we should make the links be on the same vertical slice as the logo, and maybe add a category of quick links to tools. We also need to make the links the same between the header and the footer. I will take a stab at fixing the CSS to fix alignment.

I like these changes but I don't think we have enough content in the footer to need the columns. I'm using the Red Hat page's footer (https://www.redhat.com/en) as inspiration on some thoughts: I think we should make the links be on the same vertical slice as the logo, and maybe add a category of quick links to tools. We also need to make the links the same between the header and the footer. I will take a stab at fixing the CSS to fix alignment.
ryan commented 2025-05-05 20:51:39 +00:00
Owner
Copy Link

Some more notes from the call:

  • The logo is a bit big
  • If the little button links are on the same vertical slice as the logo, it is fine to keep the links down
  • It would be nice to add a "privacy policy" that states how we don't collect users' data.
Some more notes from the call: * The logo is a bit big * If the little button links are on the same vertical slice as the logo, it is fine to keep the links down * It would be nice to add a "privacy policy" that states how we _don't_ collect users' data.
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b new-footer main
git pull origin new-footer

Step 2:

Merge the changes and update on Forgejo.
git checkout main
git merge --no-ff new-footer
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: public/website#35
No description provided.
Delete Branch "new-footer"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?