public
/
website
5
0
Fork 0
Code Issues Pull Requests 3 Packages Projects Releases Wiki Activity

feat: add blog #7

Open
anton wants to merge 15 commits from feat/blog into main
pull from: feat/blog
merge into: public:main
Conversation 0 Commits 15 Files Changed 14 +428 -46
anton commented 2024-03-29 04:14:45 +00:00
Owner
Copy Link
No description provided.
anton added 1 commit 2024-03-29 04:14:46 +00:00
anton added 1 commit 2024-03-29 04:17:38 +00:00
anton added 1 commit 2024-03-29 05:41:18 +00:00
ryan added 1 commit 2024-03-29 06:13:08 +00:00
anton added 1 commit 2024-03-29 06:18:03 +00:00
anton added 1 commit 2024-04-02 00:56:01 +00:00
danny reviewed 2024-04-02 04:40:22 +00:00
danny left a comment
First-time contributor
Copy Link

Please see https://git.distrust.co/public/website/pulls/7/files#issuecomment-385 and apply that to all references of {{ site.baseurl }}

Please see https://git.distrust.co/public/website/pulls/7/files#issuecomment-385 and apply that to all references of `{{ site.baseurl }}`
_includes/footer.html Outdated
@ -1,4 +1,4 @@
<footer style="height: 40px">
<span><img src="assets/base/distrust-white.svg" width="20px" alt="copyleft"/></span> {{ site.footer }}
<span><img src="../assets/base/distrust-white.svg" width="20px" alt="copyleft"/></span> {{ site.footer }}
danny commented 2024-04-02 04:31:15 +00:00
First-time contributor
Copy Link

This should use site absolute path

/assets/base/distrust-white.svg
This should use site absolute path ``` /assets/base/distrust-white.svg ```
anton marked this conversation as resolved
_includes/header.html Outdated
@ -4,3 +4,3 @@
<div>
<a id="home-link" href="/index.html">
<img class="menu-logo" src="assets/base/distrust-text-white.svg"
<img class="menu-logo" src="../assets/base/distrust-text-white.svg"
danny commented 2024-04-02 04:31:25 +00:00
First-time contributor
Copy Link

Same here

Same here
anton marked this conversation as resolved
_layouts/tools.html Outdated
@ -70,3 +70,3 @@
<div class="flex-container-inner">
<div class="text-well">
<h3>StageX</h3>
<h3>[Stageˣ]</h3>
danny commented 2024-04-02 04:32:36 +00:00
First-time contributor
Copy Link

To support more browsers I'd probably do

[Stage<sup>x</sup>]
To support more browsers I'd probably do ``` [Stage<sup>x</sup>] ```
anton marked this conversation as resolved
_posts/2024-03-28-introducing-distrust.md Outdated
@ -0,0 +2,4 @@
layout: post
title: Adventures In Supply Chain Integrity
date: 2024-03-28
cover_image: "../assets/images/whale_shark.jpg"
danny commented 2024-04-02 04:33:03 +00:00
First-time contributor
Copy Link

Absolute path

Absolute path
anton marked this conversation as resolved
assets/js/main.js Outdated
@ -18,2 +13,2 @@
})
.catch(error => console.error('Error loading JSON:', error));
if (window.location.pathname === "/index.html") {
fetch('../assets/js/carousel-items.json')
danny commented 2024-04-02 04:34:33 +00:00
First-time contributor
Copy Link

Absolute path

Absolute path
anton marked this conversation as resolved
blog.md Outdated
@ -0,0 +6,4 @@
<div class="posts">
{% for post in site.posts %}
<article class="post">
<h1><a href="{{ site.baseurl }}{{ post.url }}">{{ post.title }}</a></h1>
danny commented 2024-04-02 04:37:25 +00:00
First-time contributor
Copy Link

I'd probably include the title in the link as well

<a ... title="{{ post.title}}>...</a>
I'd probably include the title in the link as well ``` <a ... title="{{ post.title}}>...</a> ```
anton marked this conversation as resolved
blog.md Outdated
@ -0,0 +12,4 @@
{{ post.excerpt }}
</div>
<h4>Written on {{ post.date | date: "%B %e, %Y" }}</h4>
<a href="{{ site.baseurl }}{{ post.url }}" class="read-more">Read More</a>
danny commented 2024-04-02 04:38:59 +00:00
First-time contributor
Copy Link

Generally I'd avoid using the baseurl. This makes local development more difficult and prevents have multiple domains with the same content (eg. deploying as a Tor Hidden Service)

Generally I'd avoid using the baseurl. This makes local development more difficult and prevents have multiple domains with the same content (eg. deploying as a Tor Hidden Service)
anton marked this conversation as resolved
anton added 1 commit 2024-04-23 15:28:35 +00:00
anton added 1 commit 2024-04-23 15:52:27 +00:00
anton added 1 commit 2024-04-23 15:57:27 +00:00
anton added 2 commits 2024-04-23 16:12:23 +00:00
anton added 1 commit 2024-05-07 14:47:40 +00:00
ryan added 3 commits 2024-05-14 04:57:23 +00:00
danny reviewed 2024-06-10 16:34:22 +00:00
_config.yml
@ -40,3 +41,3 @@
# Build settings
theme: jekyll-theme-console
permalink: blog/:title.html
danny commented 2024-06-10 16:34:22 +00:00
First-time contributor
Copy Link

Doesn't this normally generate files/links in the format blog/:title/index.html?

Doesn't this normally generate files/links in the format `blog/:title/index.html`?
danny reviewed 2024-06-10 16:34:59 +00:00
_includes/footer.html
@ -1,4 +1,4 @@
<footer style="height: 40px">
<span><img src="assets/base/distrust-white.svg" width="20px" alt="copyleft"/></span> {{ site.footer }}
<span><img src="/assets/base/distrust-white.svg" width="20px" alt="copyleft"/></span> {{ site.footer }}
danny commented 2024-06-10 16:34:59 +00:00
First-time contributor
Copy Link

Would be good to use the jekyll built-in function for static assets

Would be good to use the jekyll built-in function for static assets
This pull request has changes conflicting with the target branch.
  • _includes/head.html
  • _sass/base.scss
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b feat/blog main
git pull origin feat/blog

Step 2:

Merge the changes and update on Forgejo.
git checkout main
git merge --no-ff feat/blog
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: public/website#7
No description provided.
Delete Branch "feat/blog"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?