public
/
website
5
0
Fork 0
Code Issues Pull Requests 3 Packages Projects Releases Wiki Activity

feat: add blog #7

Open
anton wants to merge 15 commits from feat/blog into main
pull from: feat/blog
merge into: public:main
Conversation 0 Commits 15 Files Changed 14 +26 -26
7 changed files with 26 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 8395fdb7f0 - Show all commits

2
_config.yml
View File

@ -40,7 +40,7 @@ footer: '2023 Distrust, LLC'
theme: jekyll-theme-console
permalink: /:title/
permalink: blog/:title/
danny commented 2024-06-10 16:34:22 +00:00
Review
Copy Link

Doesn't this normally generate files/links in the format blog/:title/index.html?

Doesn't this normally generate files/links in the format `blog/:title/index.html`?
plugins:
- jekyll-feed

2
_includes/footer.html
View File

@ -1,4 +1,4 @@
<footer style="height: 40px">
<span><img src="../assets/base/distrust-white.svg" width="20px" alt="copyleft"/></span> {{ site.footer }}
<span><img src="/assets/base/distrust-white.svg" width="20px" alt="copyleft"/></span> {{ site.footer }}
anton marked this conversation as resolved Outdated
danny commented 2024-04-02 04:31:15 +00:00
Outdated
Review
Copy Link

This should use site absolute path

/assets/base/distrust-white.svg
This should use site absolute path ``` /assets/base/distrust-white.svg ```
danny commented 2024-06-10 16:34:59 +00:00
Review
Copy Link

Would be good to use the jekyll built-in function for static assets

Would be good to use the jekyll built-in function for static assets
<script type="text/javascript" src="/assets/js/main.js"></script>
</footer>

4
_includes/header.html
View File

@ -3,7 +3,7 @@
<div class="menu">
<div>
<a id="home-link" href="/index.html">
<img class="menu-logo" src="../assets/base/distrust-text-white.svg"
<img class="menu-logo" src="/assets/base/distrust-text-white.svg"
anton marked this conversation as resolved Outdated
danny commented 2024-04-02 04:31:25 +00:00
Outdated
Review
Copy Link

Same here

Same here
alt="Distrust broken chain logo with white text" />
</a>
</div>
@ -22,7 +22,7 @@
</li>
<li class="show">
<a href="/feed.xml" style="vertical-align: middle;">
<img style="filter: grayscale(100%); width: 22px; vertical-align: sub" src="../assets/base/rss.png" />
<img style="filter: grayscale(100%); width: 22px; vertical-align: sub" src="/assets/base/rss.png" />
</a>
</li>

36
_layouts/landing.html
View File

@ -22,14 +22,14 @@
<div id="carousel"></div>
<br>
<div style="margin-left: 10px; font-size: 14px">
<a style="color: rgb(73, 73, 73)" href="../assets/js/carousel-items.json">Full list of articles</a>
<a style="color: rgb(73, 73, 73)" href="/assets/js/carousel-items.json">Full list of articles</a>
</div>
</div>
</section>
<!-- <div>
<a href="{{ site.baseurl }}{{ site.posts.first.url }}">
<img id="lp-post-img" src="{{ site.baseurl }}{{ site.posts.first.cover_image }}"
<a href="{{ site.posts.first.url }}">
<img id="lp-post-img" src="{{ site.posts.first.cover_image }}"
alt="Cover image for {{ site.posts.first.title }}">
<h2>Latest Post: {{ site.posts.first.title }}</h2>
</a>
@ -50,86 +50,86 @@
<div class="companies">
<div>
<a href="https://coinbase.com">
<img style="height: 30px" src="assets/base/companies/coinbase-white.svg" />
<img style="height: 30px" src="/assets/base/companies/coinbase-white.svg" />
</a>
</div>
<div>
<a href="https://bitgo.com">
<img src="assets/base/companies/bitgo-logo-white.svg" />
<img src="/assets/base/companies/bitgo-logo-white.svg" />
</a>
</div>
<div>
<a href="https://bishopfox.com">
<img style="height: 30px; filter: invert(100%) sepia(100%) saturate(0%) hue-rotate(288deg) brightness(102%) contrast(102%);" src="assets/base/companies/bishop-fox-dark.png" />
<img style="height: 30px; filter: invert(100%) sepia(100%) saturate(0%) hue-rotate(288deg) brightness(102%) contrast(102%);" src="/assets/base/companies/bishop-fox-dark.png" />
</a>
</div>
</div>
<div class="companies">
<div>
<a href="http://www.falconx.io/">
<img style="height: 20px" src="assets/base/companies/falconx-white.svg" />
<img style="height: 20px" src="/assets/base/companies/falconx-white.svg" />
</a>
</div>
<div>
<a href="http://www.turnkey.io/">
<img style="filter: invert(100)" src="assets/base/companies/turnkey-black.svg" />
<img style="filter: invert(100)" src="/assets/base/companies/turnkey-black.svg" />
</a>
</div>
<div>
<a href="https://exodus.com">
<img src="assets/base/companies/exodus-white.svg" />
<img src="/assets/base/companies/exodus-white.svg" />
</a>
</div>
</div>
<div class="companies">
<div>
<a href="https://siderolabs.com">
<img style="height: 60px" src="assets/base/companies/sidero-labs-white.png" />
<img style="height: 60px" src="/assets/base/companies/sidero-labs-white.png" />
</a>
</div>
<div>
<a href="https://zoom.com">
<img style="height: 35px;" src="assets/base/companies/zoom-white.png" />
<img style="height: 35px;" src="/assets/base/companies/zoom-white.png" />
</a>
</div>
<div>
<a href="https://mystenlabs.com">
<img style="height: 25px" src="assets/base/companies/mysten-labs-white.svg" />
<img style="height: 25px" src="/assets/base/companies/mysten-labs-white.svg" />
</a>
</div>
</div>
<div class="companies">
<div>
<a href="http://www.ankr.com/">
<img style="height: 75px; filter: invert(100%) sepia(100%) saturate(0%) hue-rotate(288deg) brightness(200%) contrast(102%);" src="assets/base/companies/ankr.png" />
<img style="height: 75px; filter: invert(100%) sepia(100%) saturate(0%) hue-rotate(288deg) brightness(200%) contrast(102%);" src="/assets/base/companies/ankr.png" />
</a>
</div>
<div>
<a href="http://www.hashicorp.io/">
<img style="height: 60px" src="assets/base/companies/hashicorp-white.png" />
<img style="height: 60px" src="/assets/base/companies/hashicorp-white.png" />
</a>
</div>
<div>
<a href="http://www.b1.com/">
<img style="filter: invert(100)" src="assets/base/companies/block-one-dark.svg" />
<img style="filter: invert(100)" src="/assets/base/companies/block-one-dark.svg" />
</a>
</div>
</div>
<div class="companies">
<div>
<a href="http://www.ledn.io/">
<img src="assets/base/companies/ledn-white.svg" />
<img src="/assets/base/companies/ledn-white.svg" />
</a>
</div>
<div>
<a href="https://fitbit.com">
<img src="assets/base/companies/fitbit-white.png" />
<img src="/assets/base/companies/fitbit-white.png" />
</a>
</div>
<div>
<a href="https://dfns.co">
<img src="assets/base/companies/dfns-color.png" />
<img src="/assets/base/companies/dfns-color.png" />
</a>
</div>
</div>

2
_posts/2024-03-28-introducing-distrust.md
View File

@ -2,7 +2,7 @@
layout: post
title: Adventures In Supply Chain Integrity
date: 2024-03-28
cover_image: "../assets/images/whale_shark.jpg"
cover_image: "/assets/images/whale_shark.jpg"
anton marked this conversation as resolved Outdated
danny commented 2024-04-02 04:33:03 +00:00
Outdated
Review
Copy Link

Absolute path

Absolute path
authors:
- name: Ryan Heywood
bio: Professional bonker / twerker.

2
assets/js/main.js
View File

@ -11,7 +11,7 @@ collapsibleButton.addEventListener("click", function () {
document.addEventListener('DOMContentLoaded', function () {
if (window.location.pathname === "/index.html") {
fetch('../assets/js/carousel-items.json')
fetch('/assets/js/carousel-items.json')
anton marked this conversation as resolved Outdated
danny commented 2024-04-02 04:34:33 +00:00
Outdated
Review
Copy Link

Absolute path

Absolute path
.then(response => response.json())
.then(data => {
createCarouselItems(data);

4
blog.md
View File

@ -6,13 +6,13 @@ permalink: /blog.html
<div class="posts">
{% for post in site.posts %}
<article class="post">
<h1><a href="{{ site.baseurl }}{{ post.url }}">{{ post.title }}</a></h1>
<h1><a href="{{ post.url }}" title="{{ post.title }}">{{ post.title }}</a></h1>
anton marked this conversation as resolved Outdated
danny commented 2024-04-02 04:37:25 +00:00
Outdated
Review
Copy Link

I'd probably include the title in the link as well

<a ... title="{{ post.title}}>...</a>
I'd probably include the title in the link as well ``` <a ... title="{{ post.title}}>...</a> ```
<div class="entry">
{{ post.excerpt }}
</div>
<h4>Written on {{ post.date | date: "%B %e, %Y" }}</h4>
<a href="{{ site.baseurl }}{{ post.url }}" class="read-more">Read More</a>
<a href="{{ post.url }}" class="read-more">Read More</a>
anton marked this conversation as resolved Outdated
danny commented 2024-04-02 04:38:59 +00:00
Outdated
Review
Copy Link

Generally I'd avoid using the baseurl. This makes local development more difficult and prevents have multiple domains with the same content (eg. deploying as a Tor Hidden Service)

Generally I'd avoid using the baseurl. This makes local development more difficult and prevents have multiple domains with the same content (eg. deploying as a Tor Hidden Service)
</article>
{% endfor %}
</div>